Fixed return and logging of password-like props in clear text #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/fix-password-logging
branch
4 times, most recently
from
92b218a to
20e4c1b
Compare
Details: * Increased minimum version of zhmcclient to 1.8.2 to pick up fixes for no longer logging password-like properties in clear-text. * Fixed that all password-like input parameters that were written in clear text to the module entry log are now blanked out. This affected the following modules: zhmc_ldap_server_definition, zhmc_lpar, zhmc_partition, zhmc_user. * Fixed that all password-like input parameters that were added to the module return value in clear text for 'state' values that created or updated the resource are now removed from the return value. This affected the following modules: zhmc_ldap_server_definition, zhmc_lpar, zhmc_partition. * The 'hmc_auth' input parameter is no longer completely removed from the module entry log, but instead its sensitive items 'password' and 'session_id' are now blanked out. * In support of the above, added common functions blanked_params(), blanked_dict() and removed_dict(). Added unit tests for these new functions. * Improved the end2end tests for the affected modules to check that the module output does not contain the password-like properties. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-password-logging
branch
from
20e4c1b to
08b4ceb
Compare
simon-spinner
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
End2end tests:
log_fileenabled that creates an LDAP server definition with bind password - checked the module output and the log file - passedTESTCASES=test_zhmc_ldap_server_definition.py make end2endon A224 - passedTESTCASES=test_zhmc_user.py make end2endon A224 - passedTESTCASES=test_zhmc_partition.py make end2endon A224 - passedTESTCASES=test_zhmc_ldap_server_definition.py make end2endon A224 - passedNote: test_zhmc_lpar.py was not run.