controller: fix operator crashes radondb#464 (radondb#465)

zhl003 · Jun 15, 2022 · 4a1517b · 4a1517b
1 parent a58b049
commit 4a1517b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/controllers/mysqlcluster_controller.go b/controllers/mysqlcluster_controller.go
@@ -92,7 +92,7 @@ func (r *MysqlClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request
 	oldInstance := instance.DeepCopy()
 	defer func() {
 		// TODO: Remove Status().Patch in mysqlcluster controller.
-		if !reflect.DeepEqual(oldInstance.Status, instance.Status) {
+		if instance.ObjectMeta.DeletionTimestamp == nil && !reflect.DeepEqual(oldInstance.Status, instance.Status) {
 			sErr := r.Status().Patch(ctx, instance.Unwrap(), client.MergeFrom(oldInstance))
 			if sErr != nil {
 				log.V(1).Info("failed to update cluster status", "error", sErr)