Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation methods in tasks #93

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Add validation methods in tasks #93

merged 2 commits into from
Apr 19, 2021

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Apr 19, 2021

Fixing #59

@zhiqwang zhiqwang added the enhancement New feature or request label Apr 19, 2021
@zhiqwang zhiqwang mentioned this pull request Apr 19, 2021
7 tasks
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #93 (5b461e1) into master (e827589) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   83.31%   83.35%   +0.04%     
==========================================
  Files           8        8              
  Lines         773      775       +2     
==========================================
+ Hits          644      646       +2     
  Misses        129      129              
Flag Coverage Δ
unittests 83.35% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data_pipeline.py 100.00% <100.00%> (ø)
test/test_engine.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e827589...5b461e1. Read the comment docs.

@zhiqwang zhiqwang merged commit 0248f97 into master Apr 19, 2021
@zhiqwang zhiqwang deleted the iou-validation branch April 19, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant