Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ONNXRuntime python inference. #178

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Add ONNXRuntime python inference. #178

merged 4 commits into from
Sep 28, 2021

Conversation

itsnine
Copy link
Contributor

@itsnine itsnine commented Sep 27, 2021

@zhiqwang hi, I'm already done with this feature, could you check it? Temporary I did onnxruntime-python folder, but you could restructure folders as you want.
Let me know if you have any issues.
Resolve #177

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #178 (c12b3db) into master (ed4c4eb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          10       10           
  Lines         600      600           
=======================================
  Hits          577      577           
  Misses         23       23           
Flag Coverage Δ
unittests 96.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4c4eb...c12b3db. Read the comment docs.

@zhiqwang zhiqwang added deployment Inference acceleration for production enhancement New feature or request labels Sep 28, 2021
Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itsnine , The overall looks very great to me. It is just additionally recommended to use the following process for committing PRs to keep the git history clean. I will cherry-pick directly your commits cd58b9b, db80c73 and related to merge this PR.

git remote add upstream https://github.com/zhiqwang/yolov5-rt-stack.git
git fetch upstream
git checkout -b feature  # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f

And I should add this tip to the CONTRIBUTING soon.

@zhiqwang
Copy link
Owner

Hi @itsnine , I'm merging this PR, let's refactor the restructure in #176 .

@zhiqwang zhiqwang merged commit dce0263 into zhiqwang:master Sep 28, 2021
@zhiqwang zhiqwang added the API Library use interface label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Library use interface deployment Inference acceleration for production enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ONNXRuntime Python interface
2 participants