forked from markedjs/marked
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request markedjs#1076 from joshbruce/update-templates
Release 0.3.17 (template updates) - ??
- Loading branch information
Showing
7 changed files
with
95 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,49 @@ | ||
|
||
<!-- | ||
If release PR, add ?template=release.md to the PR url to use the release PR template. | ||
Otherwise, you are stating the this PR fixes an issue that has been submitted; or, | ||
describes the issue or proposal under considersation. | ||
--> | ||
|
||
**Marked version:** | ||
|
||
<!-- The NPM version or commit hash having the issue --> | ||
|
||
## Description | ||
|
||
<!-- describe what the PR does --> | ||
- Fixes #### (if fixing a known issue; otherwise, describe issue using the following format) | ||
|
||
<!-- | ||
## Expectation | ||
Describe the output you are expecting from marked | ||
## Result | ||
Describe the output you received from marked | ||
## What was attempted | ||
- Fixes #### | ||
- Fixes list issues fixed by this PR | ||
- Fixes will automatically close them once merged | ||
Describe what code combination got you there | ||
## Review | ||
--> | ||
|
||
### Submitter | ||
## Contributor | ||
|
||
- [ ] All tests pass (CI should take care of this, once in place). | ||
- [ ] All lint checks pass (CI should take care of this, once in place). | ||
- Tests | ||
- [ ] Test(s) exist to ensure functionality works (if no new tests added, list which tests cover this functionality). | ||
- [ ] No tests required for this PR. | ||
- [ ] Is release: | ||
- [ ] Version in `package.json` has been updated (see [RELEASE.md](https://github.com/markedjs/marked/blob/master/RELEASE.md)). | ||
- [ ] The `marked.min.js` has been updated; or, | ||
- [ ] release does not change library. | ||
- [ ] Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or, | ||
- [ ] no tests required for this PR. | ||
- [ ] If submitting new feature, it has been documented in the appropriate places. | ||
|
||
## Committer | ||
|
||
### Reviewer | ||
In most cases, this should be a different person than the contributor. | ||
|
||
?? | ||
- [ ] Draft GitHub release notes have been updated. | ||
- [ ] cm_autolinks is the only failing test (remove once CI is in place and all tests pass). | ||
- [ ] All lint checks pass (remove once CI is in place). | ||
- [ ] CI is green (no forced merge required). | ||
- [ ] Merge PR |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
## Publisher | ||
|
||
- [ ] `$ npm version` has been run. | ||
- [ ] Release notes in [draft GitHub release](https://github.com/markedjs/marked/releases) are up to date | ||
- [ ] Reviewer checklist is complete. | ||
- [ ] Merge PR. | ||
- [ ] Publish GitHub release using `master` with correct version number. | ||
- [ ] `$ npm publish` has been run. | ||
- [ ] Create draft GitHub release to prepare next release. | ||
|
||
Note: If merges to `master` occur after submitting this PR and before running `$ npm pubish` you should be able to | ||
|
||
1. pull from `upstream/master` (`git pull upstream master`) into the branch holding this version, | ||
2. run `$ npm run build` to regenerate the `min` file, and | ||
3. commit and push the updated changes. | ||
|
||
## Committer | ||
|
||
In most cases, this should be someone different than the publisher. | ||
|
||
- [ ] Version in `package.json` has been updated (see [RELEASE.md](https://github.com/markedjs/marked/blob/master/RELEASE.md)). | ||
- [ ] The `marked.min.js` has been updated; or, | ||
- [ ] release does not change library. | ||
- [ ] cm_autolinks is the only failing test (remove once CI is in place and all tests pass). | ||
- [ ] All lint checks pass (remove once CI is in place). | ||
- [ ] CI is green (no forced merge required). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters