Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add External FQDN API #11

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Add External FQDN API #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99ed1ff
Add External FQDN API
ZhidaLiu Jun 24, 2021
2959a97
address comments
ZhidaLiu Jun 24, 2021
d44f88a
address comment on operationId
ZhidaLiu Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
265 changes: 265 additions & 0 deletions ...anager/Microsoft.MachineLearningServices/stable/2021-07-01/examples/ExternalFQDN/get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,265 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "workspace-1234",
"workspaceName": "testworkspace",
"api-version": "2021-07-01"
},
"responses": {
"200": {
"body": {
"value": [
{
"category": "Azure Active Directory",
"endpoints": [
{
"domainName": "login.microsoftonline.com",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "Azure portal",
"endpoints": [
{
"domainName": "management.azure.com",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "Azure Resource Manager",
"endpoints": [
{
"domainName": "management.azure.com",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "Azure Machine Learning studio",
"endpoints": [
{
"domainName": "ml.azure.com",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "API",
"endpoints": [
{
"domainName": "*.azureml.ms",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "Azure Active Directory",
"endpoints": [
{
"domainName": "login.microsoftonline.com",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "Integrated notebook",
"endpoints": [
{
"domainName": "*.notebooks.azure.net",
"endpointDetails": [
{
"port": 443
}
]
},
{
"domainName": "localtest9127254374.file.core.windows.net",
"endpointDetails": [
{
"port": 443
}
]
},
{
"domainName": "localtest9127254374.dfs.core.windows.net",
"endpointDetails": [
{
"port": 443
}
]
},
{
"domainName": "localtest9127254374.blob.core.windows.net",
"endpointDetails": [
{
"port": 443
}
]
},
{
"domainName": "graph.microsoft.com",
"endpointDetails": [
{
"port": 443
}
]
},
{
"domainName": "*.aznbcontent.net",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "Compute cluster/instance",
"endpoints": [
{
"domainName": "*.batchai.core.windows.net",
"endpointDetails": [
{
"port": 443
}
]
},
{
"domainName": "graph.windows.net",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "Compute instance",
"endpoints": [
{
"domainName": "*.instances.azureml.net",
"endpointDetails": [
{
"port": 443
}
]
},
{
"domainName": "*.instances.azureml.ms",
"endpointDetails": [
{
"port": 443
}
]
}
]
},
{
"category": "Azure Storage Account",
"endpoints": [
{
"domainName": "core.windows.net",
"endpointDetails": [
{
"port": 443
},
{
"port": 18881
},
{
"port": 8787
}
]
}
]
},
{
"category": "Azure Key Vault",
"endpoints": [
{
"domainName": "vault.azure.net",
"endpointDetails": [
{
"port": 443
},
{
"port": 18881
},
{
"port": 8787
}
]
}
]
},
{
"category": "Azure Container Registry",
"endpoints": [
{
"domainName": "azurecr.io",
"endpointDetails": [
{
"port": 443
},
{
"port": 18881
},
{
"port": 8787
}
]
}
]
},
{
"category": "Microsoft Container Registry",
"endpoints": [
{
"domainName": "mcr.microsoft.com",
"endpointDetails": [
{
"port": 443
},
{
"port": 18881
},
{
"port": 8787
}
]
}
]
}
]
}
}
}
}
93 changes: 93 additions & 0 deletions ...-manager/Microsoft.MachineLearningServices/stable/2021-07-01/machineLearningServices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1781,6 +1781,51 @@
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundNetworkDependenciesEndpoints": {
"get": {
"tags": [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to double check, this code is auto generated from swashbuckle, right? If so, can you share with me the service code PR too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can send you a draft

"ExternalFQND"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, why don't we use OutboundNetworkDependenciesEndpoints directly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is generated from the Controller name, I will modify.

],
"summary": "Called by Client (Portal, CLI, etc) to get a list of all external outbound dependencies (FQDNs) programmatically.",
"operationId": "Workspaces_ListExternalFqdnEndpoints",
"produces": [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to be OutboundNetworkDependenciesEndpoints_List

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change to that

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Capital O?

"application/json"
],
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/WorkspaceNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "Success",
"schema": {
"$ref": "#/definitions/ExternalFQDNResponse"
}
},
"default": {
"description": "Error",
"schema": {
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
}
}
},
"x-ms-examples": {
"Resync Workspace Keys": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong

"$ref": "./examples/ExternalFQDN/get.json"
}
}
}
}
},
"parameters": {
Expand Down Expand Up @@ -4802,6 +4847,54 @@
"$ref": "#/definitions/AKSProperties"
}
}
},
"FQDNEndpointDetail": {
"type": "object",
"properties": {
"port": {
"format": "int32",
"type": "integer"
}
}
},
"FQDNEndpoint": {
"type": "object",
"properties": {
"domainName": {
"type": "string"
},
"endpointDetails": {
"type": "array",
"items": {
"$ref": "#/definitions/FQDNEndpointDetail"
}
}
}
},
"FQDNEndpoints": {
"type": "object",
"properties": {
"category": {
"type": "string"
},
"endpoints": {
"type": "array",
"items": {
"$ref": "#/definitions/FQDNEndpoint"
}
}
}
},
"ExternalFQDNResponse": {
"type": "object",
"properties": {
"value": {
"type": "array",
"items": {
"$ref": "#/definitions/FQDNEndpoints"
}
}
}
}
}
}