Add module param to ignore MAC checksum errors #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odler version of zfs-crypto. Disable this by setting the optional module parameter 'zfs_crypto_ignore_checksum_errors'.
mount a previously created crypted filesystem. More details around this at zfsrogue#34
zfsrogue
added a commit
that referenced
this pull request
Dec 3, 2013
Add module param to ignore MAC checksum errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document, and implement a module param, the change in verifying MAC checksums and how to mount a previously created crypted filesystem.
More details around this at #34
I choosed the parameter 'zfs_crypto_ignore_checksum_errors' because it describe everything (and I couldn't come up with something better :). There's a lot of meta data in the parameter name, so feel free to choose a better name for it.
!! UNTESTED (but compiles without warning) !!
I was stupid enough to destroy my original filesystem as soon as I got the data moved to a newly created FS (by manually disabling the code, recompile, install the modified module and then reinstall the original one), and I don't have access to my test VM's (because of openzfs/zfs#1862 (reference)).