Skip to content

Commit

Permalink
Pickup upstream xfstest fix
Browse files Browse the repository at this point in the history
Until we can refresh xfstests to the last version we need to
pull in the following upstream change to resolve false positives
for a few test cases.

See upstream commit 774f4dd
xfstests: unify apostrophes in output files

With coreutils v8.16 the style of apostrophes changed from `word' to
'word'. This is breaking some tests which use the older form.

This commit introduces function changes the golden output of the
affected tests and introduces a filter for the older style output.

[dchinner: modified to use a global filter in check rather than
per-test filters]
[rjohnston: minor comment change]

Signed-off-by: Tomas Racek <[email protected]>
Signed-off-by: Dave Chinner <[email protected]>
Reviewed-by: Eric Sandeen <[email protected]>
Signed-off-by: Rich Johnston <[email protected]>
  • Loading branch information
behlendorf committed Oct 30, 2015
1 parent 4a2c941 commit 9df6847
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 6 deletions.
8 changes: 4 additions & 4 deletions 230.out
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ Write 4096...
pwrite64: Disk quota exceeded
Touch 3+4
Touch 5+6
touch: cannot touch `SCRATCH_MNT/file6': Disk quota exceeded
touch: cannot touch 'SCRATCH_MNT/file6': Disk quota exceeded
Touch 5
touch: cannot touch `SCRATCH_MNT/file5': Disk quota exceeded
touch: cannot touch 'SCRATCH_MNT/file5': Disk quota exceeded

### test group limit enforcement

Expand All @@ -28,6 +28,6 @@ Write 4096...
pwrite64: Disk quota exceeded
Touch 3+4
Touch 5+6
touch: cannot touch `SCRATCH_MNT/file6': Disk quota exceeded
touch: cannot touch 'SCRATCH_MNT/file6': Disk quota exceeded
Touch 5
touch: cannot touch `SCRATCH_MNT/file5': Disk quota exceeded
touch: cannot touch 'SCRATCH_MNT/file5': Disk quota exceeded
2 changes: 1 addition & 1 deletion 235.out
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Group used soft hard grace used soft hard grace
fsgqa -- 0 0 0 1 0 0


touch: cannot touch `SCRATCH_MNT/failed': Read-only file system
touch: cannot touch 'SCRATCH_MNT/failed': Read-only file system
*** Report for user quotas on device SCRATCH_DEV
Block grace time: 7days; Inode grace time: 7days
Block limits File limits
Expand Down
2 changes: 1 addition & 1 deletion 245.out
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
QA output created by 245
mv: cannot move `TEST_DIR/test-mv/ab/aa/' to `TEST_DIR/test-mv/aa': File exists
mv: cannot move 'TEST_DIR/test-mv/ab/aa/' to 'TEST_DIR/test-mv/aa': File exists
4 changes: 4 additions & 0 deletions check
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,10 @@ do
echo " - no qualified output"
err=true
else

# coreutils 8.16+ changed quote formats in error messages from
# `foo' to 'foo'. Filter old versions to match the new version.
sed -i "s/\`/\'/g" $tmp.out
if diff $seq.out $tmp.out >/dev/null 2>&1
then
if $err
Expand Down
1 change: 1 addition & 0 deletions common.config
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
# all tests should use a common language setting to prevent golden
# output mismatches.
export LANG=C
export LC_ALL=C

# Warning: don't put freeware before /usr/bsd on IRIX coz you'll
# get the wrong hostname and set your system name to -s :)
Expand Down

0 comments on commit 9df6847

Please sign in to comment.