This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Improved update operations #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evidently, the package is available via the operation instance composed in the event, and both the operation and the event are immutable. As such, this requires a different approach to updating: - We need to grab the operation from the provided PackageEvent - We need to retrieve the initial and target packages from the operation - We need to build a new package event for the uninstall operation that includes a new UninstallOperation instance composing the initial package. - We need to build a new package event for the install operation that includes a new InstallOperation instance composing the target package. This patch adds a method for creating a new PackageEvent based on the original, but containing the new operation provided, and updates the `onPostPackageUpdate()` method to call on this method, providing an appropriate operation composing the appropriate package instance. The results have been integration tested in an existing application, and I have verified that the assets were updated.
weierophinney
added a commit
that referenced
this pull request
Aug 12, 2016
weierophinney
added a commit
that referenced
this pull request
Aug 12, 2016
weierophinney
added a commit
that referenced
this pull request
Aug 12, 2016
Forward port #3 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidently, the package is available via the operation instance composed in the event, and both the operation and the event are immutable. As such, this requires a different approach to updating:
This patch adds a method for creating a new PackageEvent based on the original, but containing the new operation provided, and updates the
onPostPackageUpdate()method to call on this method, providing an appropriate operation composing the appropriate package instance.The results have been integration tested in an existing application, and I have verified that the assets were updated.