feat!: separate search module #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve integrations with a generic to better type the returned value Refs: SHELL-260
This comment has been minimized.
This comment has been minimized.
3 tasks
The condition was placed there to prevent saving search params for search route. The logic has been moved to search module
This comment has been minimized.
This comment has been minimized.
…apps Refs: SHELL-260
This comment has been minimized.
This comment has been minimized.
3 tasks
CataldoMazzilli
previously approved these changes
Dec 10, 2024
rodleyorosa
previously approved these changes
Dec 11, 2024
beawar
dismissed stale reviews from rodleyorosa and CataldoMazzilli
via
54b461d
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CataldoMazzilli
previously approved these changes
Dec 13, 2024
rodleyorosa
previously approved these changes
Dec 13, 2024
beawar
dismissed stale reviews from rodleyorosa and CataldoMazzilli
via
8294855
This comment has been minimized.
This comment has been minimized.
CataldoMazzilli
previously approved these changes
Dec 16, 2024
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 16, 2024
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: carbonio-shell-ui |
CataldoMazzilli
approved these changes
Dec 18, 2024
rodleyorosa
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove all exports related to the search. Search functions and components must be used through the integrations exposed by the search module.
Refs: SHELL-260