-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove router inside boards #434
Merged
CataldoMazzilli
merged 5 commits into
24.9
from
SHELL-204-BC-Remove-Router-inside-Boards
Jun 12, 2024
Merged
refactor!: remove router inside boards #434
CataldoMazzilli
merged 5 commits into
24.9
from
SHELL-204-BC-Remove-Router-inside-Boards
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove moment from the dependencies and from the shared libraries. Refs: SHELL-218 SHELL-164 (#425)
BREAKING CHANGE: remove router inside boards BREAKING CHANGE: change addBoard api BREAKING CHANGE: change addBoardView api BREAKING CHANGE: update Board type Refs: SHELL-204
…Router-inside-Boards
Analysis Details0 IssuesCoverage and DuplicationsProject ID: carbonio-shell-ui |
1 similar comment
Analysis Details0 IssuesCoverage and DuplicationsProject ID: carbonio-shell-ui |
beawar
approved these changes
Jun 10, 2024
Analysis Details0 IssuesCoverage and DuplicationsProject ID: carbonio-shell-ui |
Analysis Details0 IssuesCoverage and DuplicationsProject ID: carbonio-shell-ui |
beawar
approved these changes
Jun 11, 2024
Analysis Details0 IssuesCoverage and DuplicationsProject ID: carbonio-shell-ui |
rodleyorosa
approved these changes
Jun 12, 2024
beawar
pushed a commit
that referenced
this pull request
Jun 12, 2024
BREAKING CHANGE: remove router inside boards BREAKING CHANGE: change addBoard api BREAKING CHANGE: change addBoardView api BREAKING CHANGE: update Board type Refs: SHELL-204 (#434)
beawar
pushed a commit
that referenced
this pull request
Jun 24, 2024
BREAKING CHANGE: remove router inside boards BREAKING CHANGE: change addBoard api BREAKING CHANGE: change addBoardView api BREAKING CHANGE: update Board type Refs: SHELL-204 (#434)
beawar
pushed a commit
that referenced
this pull request
Jun 25, 2024
BREAKING CHANGE: remove router inside boards BREAKING CHANGE: change addBoard api BREAKING CHANGE: change addBoardView api BREAKING CHANGE: update Board type Refs: SHELL-204 (#434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove router inside boards
BREAKING CHANGE: change addBoard api
BREAKING CHANGE: change addBoardView api
BREAKING CHANGE: update Board type
Refs: SHELL-204