Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove router inside boards #434

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

CataldoMazzilli
Copy link
Member

BREAKING CHANGE: remove router inside boards
BREAKING CHANGE: change addBoard api
BREAKING CHANGE: change addBoardView api
BREAKING CHANGE: update Board type

Refs: SHELL-204

beawar and others added 2 commits June 10, 2024 09:35
Remove moment from the dependencies and from the shared libraries.

Refs: SHELL-218 SHELL-164 (#425)
BREAKING CHANGE: remove router inside boards
BREAKING CHANGE: change addBoard api
BREAKING CHANGE: change addBoardView api
BREAKING CHANGE: update Board type

Refs: SHELL-204
@CataldoMazzilli CataldoMazzilli requested review from a team as code owners June 10, 2024 12:41
@CataldoMazzilli CataldoMazzilli self-assigned this Jun 10, 2024
Copy link

Failed

  • 44.40% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 44.40% Coverage (63.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

1 similar comment
Copy link

Failed

  • 44.40% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 44.40% Coverage (63.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

src/shell/boards/board.tsx Outdated Show resolved Hide resolved
@beawar beawar changed the base branch from devel to 24.9 June 11, 2024 07:43
Copy link

Failed

  • 44.40% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 44.40% Coverage (63.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@CataldoMazzilli CataldoMazzilli requested a review from beawar June 11, 2024 08:24
Copy link

Failed

  • 68.80% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 68.80% Coverage (63.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

Copy link

Failed

  • 68.80% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 68.80% Coverage (63.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@CataldoMazzilli CataldoMazzilli merged commit 7520f97 into 24.9 Jun 12, 2024
2 of 3 checks passed
@CataldoMazzilli CataldoMazzilli deleted the SHELL-204-BC-Remove-Router-inside-Boards branch June 12, 2024 10:23
beawar pushed a commit that referenced this pull request Jun 12, 2024
BREAKING CHANGE: remove router inside boards
BREAKING CHANGE: change addBoard api
BREAKING CHANGE: change addBoardView api
BREAKING CHANGE: update Board type

Refs: SHELL-204 (#434)
beawar pushed a commit that referenced this pull request Jun 24, 2024
BREAKING CHANGE: remove router inside boards
BREAKING CHANGE: change addBoard api
BREAKING CHANGE: change addBoardView api
BREAKING CHANGE: update Board type

Refs: SHELL-204 (#434)
beawar pushed a commit that referenced this pull request Jun 25, 2024
BREAKING CHANGE: remove router inside boards
BREAKING CHANGE: change addBoard api
BREAKING CHANGE: change addBoardView api
BREAKING CHANGE: update Board type

Refs: SHELL-204 (#434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants