-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix search bar bug that grows in width #315
fix: fix search bar bug that grows in width #315
Conversation
refs: SHELL-49
…g-in-the-search-bar-the-ui-is-forced-to-move-to-left
I simply used the vw (viewport width) to manage the sizing of this element in relation to the width of the browser window. |
…g-in-the-search-bar-the-ui-is-forced-to-move-to-left
refs: SHELL-49
…rch-bar-the-ui-is-forced-to-move-to-left' of github.com:Zextras/carbonio-shell-ui into SHELL-49-bug-typing-a-keyword-extremely-long-in-the-search-bar-the-ui-is-forced-to-move-to-left
…g-in-the-search-bar-the-ui-is-forced-to-move-to-left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By removing the maxWidth in the shell-header, we are removing the reserved space for the utility actions. I'm not crazy about it. But I think we need to review the spaces and widths of the entire header, and so I'm going to accept this for now
…g-in-the-search-bar-the-ui-is-forced-to-move-to-left
refs: SHELL-49