Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix search bar bug that grows in width #315

Conversation

rodleyorosa
Copy link
Contributor

refs: SHELL-49

…g-in-the-search-bar-the-ui-is-forced-to-move-to-left
@rodleyorosa
Copy link
Contributor Author

I simply used the vw (viewport width) to manage the sizing of this element in relation to the width of the browser window.

rodleyorosa and others added 3 commits August 23, 2023 14:25
…g-in-the-search-bar-the-ui-is-forced-to-move-to-left
…rch-bar-the-ui-is-forced-to-move-to-left' of github.com:Zextras/carbonio-shell-ui into SHELL-49-bug-typing-a-keyword-extremely-long-in-the-search-bar-the-ui-is-forced-to-move-to-left
…g-in-the-search-bar-the-ui-is-forced-to-move-to-left
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing the maxWidth in the shell-header, we are removing the reserved space for the utility actions. I'm not crazy about it. But I think we need to review the spaces and widths of the entire header, and so I'm going to accept this for now

…g-in-the-search-bar-the-ui-is-forced-to-move-to-left
@rodleyorosa rodleyorosa merged commit ed4194a into devel Aug 28, 2023
@rodleyorosa rodleyorosa deleted the SHELL-49-bug-typing-a-keyword-extremely-long-in-the-search-bar-the-ui-is-forced-to-move-to-left branch August 28, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants