build(deps): update tinymce to 6.6.1 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: SHELL-151
nubsthead
previously approved these changes
Aug 17, 2023
CataldoMazzilli
previously approved these changes
Aug 21, 2023
refactor: extract the supported locales to a constants By extracting the locales fixed values to a const object, it is possible to use this object from the webpack compilation file, limiting the definition of the supported locales to a single point. Inside the webpack config, it is now possible to read this object in order to include inside the bundle only the supported locales for both tinymce and date-fns. fix: add missing translations for locales label of settings chore: update tinymce translations files Add a field in the supported translations object to map the locale of i18n to the tinymce one, as already done for date-fns. refactor: move webpack config to ts Compile the config before running the build script in order to make it visible to the sdk. Add compiled files to .gitignore. Remove the compiled files after the build. refs: SHELL-151
nubsthead
previously approved these changes
Aug 23, 2023
gnekoz
previously approved these changes
Aug 23, 2023
CataldoMazzilli
previously approved these changes
Aug 23, 2023
beawar
dismissed stale reviews from CataldoMazzilli, gnekoz, and nubsthead
via
6f776ec
CataldoMazzilli
approved these changes
Aug 23, 2023
CerDennis
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: SHELL-151