Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove feedback from UI #299

Merged
merged 3 commits into from
Aug 7, 2023
Merged

feat: remove feedback from UI #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caee955
feat: remove feedback from UI
rodleyorosa Aug 1, 2023
81a2cb1
feat: remove feedback store and mocks
rodleyorosa Aug 2, 2023
7949ad5
Merge branch 'devel' into SHELL-140-remove-feedback-form-from-ui
rodleyorosa Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/boot/app/default-views.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { size } from 'lodash';

import type { AppState, PrimaryBarView, SettingsView } from '../../../types';
import { SEARCH_APP_ID, SETTINGS_APP_ID, SHELL_APP_ID } from '../../constants';
import Feedback from '../../reporting/feedback';
import { SearchAppView } from '../../search/search-app-view';
import { AccountsSettings } from '../../settings/accounts-settings';
import GeneralSettings from '../../settings/general-settings';
Expand Down Expand Up @@ -97,12 +96,6 @@ const searchAppView = {
component: SearchAppView
};

const feedbackBoardView = {
id: 'feedback',
app: SHELL_APP_ID,
component: Feedback,
route: 'feedback'
};
export const registerDefaultViews = (t: TFunction): void => {
useAppStore.setState(
produce((s: AppState) => {
Expand All @@ -123,7 +116,6 @@ export const registerDefaultViews = (t: TFunction): void => {
s.views.appView = [searchAppView, settingsAppView];
s.views.settings = [settingsGeneralView(t), settingsAccountsView(t)];
}
s.views.board = [feedbackBoardView];
})
);
};
2 changes: 0 additions & 2 deletions src/constants/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ export const SCALING_LIMIT = {
export const LOGIN_V3_CONFIG_PATH = '/zx/login/v3/config';
export const DARK_READER_PROP_KEY = 'zappDarkreaderMode';
export const SENTRY_SHELL_DSN = 'https://[email protected]/6';
export const SENTRY_FEEDBACK_DNS =
'https://[email protected]/8';

export enum ResultLabelType {
NORMAL = 'normal',
Expand Down
2 changes: 0 additions & 2 deletions src/reporting/__mocks__/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,3 @@
import * as actualFunctions from '../functions';

export const report: typeof actualFunctions.report = () => (): string => '';

export const feedback: typeof actualFunctions.feedback = (): string => '';
Loading