feat: avoid to call getRightsRequest on every mount

src/mocks/handlers/getRightsRequest.ts

@@ -8,14 +8,14 @@ import { type ResponseResolver, type RestContext, type RestRequest } from 'msw';
 
 import { GetRightsResponse } from '../../../types';
 
-type GetRightsRequestBody = {
+export type GetRightsRequestBody = {
 	GetRightsRequest: {
 		_jsns: string;
 		ace: Array<{ right: string }>;
 	};
 };
 
-type GetRightsResponseBody = {
+export type GetRightsResponseBody = {
 	Body: {
 		GetRightsResponse: GetRightsResponse;
 		Fault?: { Detail?: { Error?: { Code?: string; Detail?: string } }; Reason?: { Text: string } };

src/settings/accounts-settings.test.tsx

@@ -10,9 +10,15 @@ import { faker } from '@faker-js/faker';
 import { act, screen, waitFor, within } from '@testing-library/react';
 import { head, shuffle, tail } from 'lodash';
 import { rest } from 'msw';
+import { Link, Route, Switch } from 'react-router-dom';
 
 import { AccountsSettings } from './accounts-settings';
 import { Account, BatchRequest, CreateIdentityResponse, Identity } from '../../types';
+import {
+	GetRightsRequestBody,
+	GetRightsResponseBody,
+	getRightsRequest
+} from '../mocks/handlers/getRightsRequest';
 import server, { waitForRequest } from '../mocks/server';
 import { useAccountStore } from '../store/account';
 import { setup } from '../test/utils';
@@ -1596,7 +1602,6 @@ describe('Account setting', () => {
 			expect(screen.getByRole('button', { name: /save/i })).toBeEnabled();
 
 			await user.click(screen.getByRole('button', { name: /save/i }));
-
 			const request = await pendingBatchRequest;
 			const requestBody = (request?.body as { Body: { BatchRequest: BatchRequest } }).Body;
 			expect(requestBody.BatchRequest.CreateIdentityRequest).toBeUndefined();
@@ -1610,5 +1615,160 @@ describe('Account setting', () => {
 			const successSnackbar = await screen.findByText('Edits saved correctly');
 			expect(successSnackbar).toBeVisible();
 		});
+		test('GetRightRequest is called only once when the user navigates inside account settings', async () => {
+			const defaultFirstName = faker.person.firstName();
+			const defaultLastName = faker.person.lastName();
+			const defaultFullName = faker.person.fullName({
+				firstName: defaultFirstName,
+				lastName: defaultLastName
+			});
+			const defaultEmail = faker.internet.email({
+				firstName: defaultFirstName,
+				lastName: defaultLastName
+			});
+			const defaultId = faker.string.uuid();
+
+			const identitiesArray: Account['identities']['identity'] = [
+				{
+					id: defaultId,
+					name: 'DEFAULT',
+					_attrs: {
+						zimbraPrefIdentityName: defaultFullName,
+						zimbraPrefReplyToEnabled: 'FALSE',
+						zimbraPrefFromDisplay: defaultFirstName,
+						zimbraPrefFromAddress: defaultEmail,
+						zimbraPrefIdentityId: defaultId,
+						zimbraPrefFromAddressType: 'sendAs'
+					}
+				}
+			];
+
+			const account: Account = {
+				name: defaultEmail,
+				rights: { targets: [] },
+				signatures: { signature: [] },
+				id: defaultId,
+				displayName: '',
+				identities: {
+					identity: identitiesArray
+				}
+			};
+
+			useAccountStore.setState((previousState) => ({
+				...previousState,
+				account
+			}));
+
+			const requestFn = jest.fn();
+			server.use(
+				rest.post<GetRightsRequestBody, never, GetRightsResponseBody>(
+					'/service/soap/GetRightsRequest',
+					(req, res, context) => {
+						requestFn();
+						return getRightsRequest(req, res, context);
+					}
+				)
+			);
+
+			const TestComponent = (): JSX.Element => (
+				<>
+					<Switch>
+						<Route path="/other">
+							<div>
+								<span data-testid="text">Other page</span>
+								<Link to="/settings/accounts">Go to Account Settings</Link>
+							</div>
+						</Route>
+						<Route path="/settings/accounts">
+							<AccountsSettings />
+							<Link to="/other">Go to Other page</Link>
+						</Route>
+					</Switch>
+				</>
+			);
+
+			const { user } = setup(<TestComponent />, { initialRouterEntries: [`/settings/accounts`] });
+
+			await waitForGetRightsRequest();
+			expect(requestFn).toHaveBeenCalledTimes(1);
+			expect(screen.queryByTestId('text')).not.toBeInTheDocument();
+			expect(screen.getByText(/Accounts List/i)).toBeVisible();
+			await user.click(screen.getByRole('link', { name: 'Go to Other page' }));
+			expect(screen.queryByTestId('text')).toBeVisible();
+			expect(screen.queryByText('sendAs')).not.toBeInTheDocument();
+			await user.click(screen.getByRole('link', { name: 'Go to Account Settings' }));
+			expect(screen.getByText('sendAs')).toBeVisible();
+			expect(requestFn).toHaveBeenCalledTimes(1);
+		});
+
+		test('When rights state is updated, the delegates list will be updated accordingly', async () => {
+			const defaultFirstName = faker.person.firstName();
+			const defaultLastName = faker.person.lastName();
+			const defaultFullName = faker.person.fullName({
+				firstName: defaultFirstName,
+				lastName: defaultLastName
+			});
+			const defaultEmail = faker.internet.email({
+				firstName: defaultFirstName,
+				lastName: defaultLastName
+			});
+			const defaultId = faker.string.uuid();
+
+			const identitiesArray: Account['identities']['identity'] = [
+				{
+					id: defaultId,
+					name: 'DEFAULT',
+					_attrs: {
+						zimbraPrefIdentityName: defaultFullName,
+						zimbraPrefReplyToEnabled: 'FALSE',
+						zimbraPrefFromDisplay: defaultFirstName,
+						zimbraPrefFromAddress: defaultEmail,
+						zimbraPrefIdentityId: defaultId,
+						zimbraPrefFromAddressType: 'sendAs'
+					}
+				}
+			];
+
+			const account: Account = {
+				name: defaultEmail,
+				rights: { targets: [] },
+				signatures: { signature: [] },
+				id: defaultId,
+				displayName: '',
+				identities: {
+					identity: identitiesArray
+				}
+			};
+
+			useAccountStore.setState((previousState) => ({
+				...previousState,
+				account
+			}));
+
+			const requestFn = jest.fn();
+			server.use(
+				rest.post<GetRightsRequestBody, never, GetRightsResponseBody>(
+					'/service/soap/GetRightsRequest',
+					(req, res, context) => {
+						requestFn();
+						return getRightsRequest(req, res, context);
+					}
+				)
+			);
+
+			setup(<AccountsSettings />);
+
+			await waitForGetRightsRequest();
+			expect(requestFn).toHaveBeenCalledTimes(1);
+			expect(screen.getByText(/Accounts List/i)).toBeVisible();
+
+			act(() => {
+				useAccountStore.setState((previousState) => ({
+					...previousState,
+					rights: []
+				}));
+			});
+			expect(screen.queryByText('sendAs')).not.toBeInTheDocument();
+		});
 	});
 });

src/settings/accounts-settings.tsx

@@ -40,6 +40,7 @@ import {
 	AccountState
 } from '../../types';
 import type { ModifyIdentityRequest } from '../../types';
+import { AccountACEInfo } from '../../types/network/entities';
 import { SHELL_APP_ID } from '../constants';
 import { getSoapFetch } from '../network/fetch';
 import { useAccountStore, useUserAccount, useUserSettings } from '../store/account';
@@ -88,6 +89,26 @@ function mapToModifyIdentityRequests(
 	);
 }
 
+function generateDelegateList(ace: AccountACEInfo[] | undefined): DelegateType[] {
+	return reduce(
+		ace,
+		(accumulator: Array<DelegateType>, item, idx) => {
+			const index = findIndex(accumulator, { email: item.d });
+			if (index === -1) {
+				accumulator.push({ email: item.d || '', right: item.right, id: idx.toString() });
+			} else {
+				accumulator[index] = {
+					email: item.d || '',
+					right: `${item.right} and ${accumulator[index].right}`,
+					id: idx.toString()
+				};
+			}
+			return accumulator;
+		},
+		[]
+	);
+}
+
 export const AccountsSettings = (): JSX.Element => {
 	const [t] = useTranslation();
 	const createSnackbar = useSnackbar();
@@ -346,35 +367,27 @@ export const AccountsSettings = (): JSX.Element => {
 
 	const [delegates, setDelegates] = useState<DelegateType[]>([]);
 
+	const rights = useAccountStore((state) => state.rights);
+
 	useEffect(() => {
-		getSoapFetch(SHELL_APP_ID)<GetRightsRequest, GetRightsResponse>('GetRights', {
-			_jsns: 'urn:zimbraAccount',
-			ace: [{ right: 'sendAs' }, { right: 'sendOnBehalfOf' }]
-		}).then((value) => {
-			if (value.ace) {
-				const { ace } = value;
-				const result = reduce(
-					ace,
-					(accumulator: Array<DelegateType>, item, idx) => {
-						const index = findIndex(accumulator, { email: item.d });
-						if (index === -1) {
-							accumulator.push({ email: item.d || '', right: item.right, id: idx.toString() });
-						} else {
-							accumulator.push({
-								email: item.d || '',
-								right: `${item.right} and ${accumulator[index].right}`,
-								id: idx.toString()
-							});
-							accumulator.splice(index, 1);
-						}
-						return accumulator;
-					},
-					[]
-				);
-				setDelegates(result);
-			}
-		});
-	}, []);
+		if (!rights) {
+			getSoapFetch(SHELL_APP_ID)<GetRightsRequest, GetRightsResponse>('GetRights', {
+				_jsns: 'urn:zimbraAccount',
+				ace: [{ right: 'sendAs' }, { right: 'sendOnBehalfOf' }]
+			}).then((value) => {
+				if (value.ace) {
+					const { ace } = value;
+					setDelegates(generateDelegateList(ace));
+				}
+				useAccountStore.setState((state) => ({
+					...state,
+					rights: value.ace ?? []
+				}));
+			});
+		} else {
+			setDelegates(generateDelegateList(rights));
+		}
+	}, [rights]);
 
 	const personaSettings = useMemo<JSX.Element | null>(() => {
 		const identity = identities[selectedIdentityId];

src/store/account/store.ts

@@ -12,6 +12,7 @@ import type { AccountState } from '../../../types';
 export const useAccountStore = create<AccountState>()(() => ({
 	authenticated: false,
 	account: undefined,
+	rights: undefined,
 	version: '',
 	settings: {
 		prefs: {},

types/account/index.d.ts

@@ -8,6 +8,7 @@ import { DARK_READER_PROP_KEY, DELEGATED_SEND_SAVE_TARGET } from '../../src/cons
 import { StringOfLength } from '../../src/utils/typeUtils';
 import type { SHELL_APP_ID } from '../exports';
 import type { DarkReaderPropValues } from '../misc';
+import { AccountACEInfo } from '../network/entities';
 
 export interface ZimletProp {
 	name: string;
@@ -31,6 +32,7 @@ export type SoapFetch = <Request, Response>(
 export type AccountState = {
 	authenticated: boolean;
 	account?: Account;
+	rights?: Array<AccountACEInfo>;
 	settings: AccountSettings;
 	zimbraVersion?: string;
 	usedQuota: number;

types/network/entities.d.ts

@@ -3,6 +3,61 @@
  *
  * SPDX-License-Identifier: AGPL-3.0-only
  */
+// The type of grantee:
+export type GranteeType =
+	// usr - Zimbra user
+	| 'usr'
+	// grp - Zimbra group(distribution list)
+	| 'grp'
+	// an external AD group
+	| 'egp'
+	// all - all authenticated users
+	| 'all'
+	// Zimbra Domain
+	| 'dom'
+	// non-Zimbra domain (used with sendToDistList right)
+	| 'edom'
+	// gst - non-Zimbra email address and password (not yet supported)
+	| 'gst'
+	// key - external user with an accesskey
+	| 'key'
+	// pub - public authenticated and unauthenticated access
+	| 'pub'
+	// Pseudo grantee type.  Granting code will map to usr/grp/egp or gst
+	| 'email';
+
+export type Right =
+	// Following rights are partial, they are the result of
+	// description: automatically add meeting invites from grantee to the target's calendar
+	// right type: preset
+	// target type(s): account
+	// grant target type: (default)
+	// right class: USER
+	| 'invite'
+	// description: login as another user.  Currently this is only honored for imap/pop3 login.
+	// right type: preset
+	// target type(s): account
+	// grant target type: (default)
+	// right class: USER
+	| 'loginAs'
+	// description: reply to messages in a shared folder as the owner of the folder
+	// right type: preset
+	// target type(s): account
+	// grant target type: account
+	// right class: USER
+	| 'sendAs'
+	// description: send messages on behalf of the grantor
+	// right type: preset
+	// target type(s): account
+	// grant target type: account
+	// right class: USER
+	| 'sendOnBehalfOf'
+	// description: view free/busy
+	// right type: preset
+	// target type(s): account
+	// grant target type: (default)
+	// right class: USER
+	| 'viewFreeBusy';
 
 /** Specify Access Control Entries */
 export interface AccountACEInfo {
@@ -32,9 +87,9 @@ export interface AccountACEInfo {
 	 * if key is not given, server will generate an access key
 	 * If chkgt is "1 (true)", INVALID_REQUEST will be thrown if wrong grantee type is specified.
 	 */
-	gt: 'usr' | 'grp' | 'egp' | 'all' | 'dom' | 'edom' | 'gst' | 'key' | 'pub' | 'email';
+	gt: GranteeType;
 	/** Right */
-	right: 'viewFreeBusy' | 'invite';
+	right: Right;
 	/**
 	 * Name or email address of the grantee.
 	 * Not present if {grantee-type} is "all" or "pub"