feat: allow the user to move the board #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: SHELL-98 SHELL-27
refs: SHELL-98
refs: SHELL-98
refs: SHELL-98
Use last saved sizes as dimensions of a new board. If there is no saved size, use defaults. Update defaults to be responsive and to respect 4/3 aspect ratio. refs: SHELL-98 SHELL-97
refs: SHELL-98
…ser-to-resize-the-board
refs: SHELL-98
refs: SHELL-98
refs: SHELL-100 SHELL-27
fix: prevent board from moving when resizing under min size refs: SHELL-27 SHELL-98 SHELL-102
…ser-to-resize-the-board
refs: SHELL-102
refs: SHELL-102
refs: SHELL-100
refs: SHELL-99 SHELL-27
Prevent move of new board to reset size by initializing the internal ref with the local storage value. Prevent board position to be calculated when collapsed, since the board container has size 0 and the calculation will result in a negative value. Remove listener of the click on mouseUp to always clean it up refs: SHELL-99
beawar
requested review from
nubsthead,
giuliano176 and
AlessioCrestani
and removed request for
a team
Click event can be fired after the mouse up, so removing the listener on mouse up is causing the click to be triggerd after a move. refs: SHELL-99
beawar
requested review from
nubsthead,
giuliano176,
AlessioCrestani and
a team
and removed request for
a team,
nubsthead,
giuliano176 and
AlessioCrestani
refs: SHELL-99
refs: SHELL-100
refs: SHELL-98
…-99-allow-the-user-to-move-the-board
refs: SHELL-99
refs: SHELL-99
refs: SHELL-100
…-99-allow-the-user-to-move-the-board
refs: SHELL-99
…-99-allow-the-user-to-move-the-board
refs: SHELL-99
Base automatically changed from
SHELL-98-allow-the-user-to-resize-the-board
to
SHELL-27-resize-and-move-board
June 5, 2023 17:16
…into SHELL-99-allow-the-user-to-move-the-board
refs: SHELL-99
CataldoMazzilli
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: SHELL-27 SHELL-99