Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the user to resize and move the board #262

Merged
merged 8 commits into from
Jun 20, 2023

Conversation

beawar
Copy link
Contributor

@beawar beawar commented Jun 6, 2023

Make board resizable through the drag of the borders.
Save last sizes in local storage and use it when opening new boards.
Update default size to be responsive based on height of the screen and to respect the 4:3 aspect ratio.
Add action to reset board size and position to default one.
Keep board visible for at least one of its borders when resizing the window and a custom size and position was manually set for the board.
Make board movable through the drag of the header
Propagate updates of the local storage to all usages, both in the same and cross window

refs: SHELL-27

beawar added 2 commits June 5, 2023 19:16
Make board resizable through the drag of the borders.
Save last sizes in local storage and use it when opening new boards.
Update default size to be responsive based on height of the screen and to respect the 4:3 aspect ratio.
Add action to reset board size and position to default one.
Keep board visible for at least one of its borders when resizing the window and a custom size and position was manually set for the board.

refs: SHELL-27 SHELL-97 SHELL-98 SHELL-100 SHELL-102

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* feat: allow the user to move the board
* fix: propagate local storage updates globally to each hook usage

refs: SHELL-27 SHELL-99 (#257)
@beawar beawar requested review from a team as code owners June 6, 2023 10:24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
CataldoMazzilli
CataldoMazzilli previously approved these changes Jun 6, 2023
@beawar beawar self-assigned this Jun 7, 2023
nubsthead
nubsthead previously approved these changes Jun 7, 2023
Copy link
Contributor Author

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add a couple of tests to the hook to avoid this kind of error in the future

src/shell/hooks/useLocalStorage.ts Outdated Show resolved Hide resolved
Value received from the set can be a function, but the store
should contain only the computed value. It should be a clone
of the local storage.

Avoid to set initial value inside store on read if a value is already present.

Add test for checking local storage and store updates.

Fix mock of zustand which was not really resetting the store to
initial value between tests.

Add util to export things for tests only.

Update zustand dependency

refs: SHELL-27
@beawar beawar dismissed stale reviews from nubsthead and CataldoMazzilli via 6c3c7f1 June 7, 2023 18:08
__mocks__/zustand/index.ts Outdated Show resolved Hide resolved
src/shell/hooks/useLocalStorage.test.tsx Show resolved Hide resolved
beawar added 2 commits June 16, 2023 11:18
Revert changes made to the mock of zustand

refs: SHELL-27
…ault

Reset action was not disabled when opening a new board which had
custom position and default size.

refs: SHELL-27
@beawar beawar merged commit e266ca8 into devel Jun 20, 2023
@beawar beawar deleted the SHELL-27-resize-and-move-board branch June 20, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants