-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow the user to resize and move the board #262
Merged
+2,869
−335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make board resizable through the drag of the borders. Save last sizes in local storage and use it when opening new boards. Update default size to be responsive based on height of the screen and to respect the 4:3 aspect ratio. Add action to reset board size and position to default one. Keep board visible for at least one of its borders when resizing the window and a custom size and position was manually set for the board. refs: SHELL-27 SHELL-97 SHELL-98 SHELL-100 SHELL-102
* feat: allow the user to move the board * fix: propagate local storage updates globally to each hook usage refs: SHELL-27 SHELL-99 (#257)
CataldoMazzilli
previously approved these changes
Jun 6, 2023
nubsthead
previously approved these changes
Jun 7, 2023
beawar
commented
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to add a couple of tests to the hook to avoid this kind of error in the future
Value received from the set can be a function, but the store should contain only the computed value. It should be a clone of the local storage. Avoid to set initial value inside store on read if a value is already present. Add test for checking local storage and store updates. Fix mock of zustand which was not really resetting the store to initial value between tests. Add util to export things for tests only. Update zustand dependency refs: SHELL-27
nubsthead
reviewed
Jun 15, 2023
Revert changes made to the mock of zustand refs: SHELL-27
…ault Reset action was not disabled when opening a new board which had custom position and default size. refs: SHELL-27
nubsthead
approved these changes
Jun 16, 2023
CerDennis
approved these changes
Jun 19, 2023
CataldoMazzilli
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make board resizable through the drag of the borders.
Save last sizes in local storage and use it when opening new boards.
Update default size to be responsive based on height of the screen and to respect the 4:3 aspect ratio.
Add action to reset board size and position to default one.
Keep board visible for at least one of its borders when resizing the window and a custom size and position was manually set for the board.
Make board movable through the drag of the header
Propagate updates of the local storage to all usages, both in the same and cross window
refs: SHELL-27