Skip to content

Commit

Permalink
fix: removed hardcoded labels
Browse files Browse the repository at this point in the history
  • Loading branch information
giuliano176 authored and zovomat committed Mar 28, 2022
1 parent 93e9a5b commit b27113f
Show file tree
Hide file tree
Showing 5 changed files with 357 additions and 344 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,18 @@ const ExternalAccount = ({ t }: ExternalAccountProps): ReactElement => {
mainAlignment="flex-start"
>
<Row width="50%" padding={{ right: 'small' }}>
<Input label="Email Address" value="[email protected]" background="gray5" />
<Input
label={t('label.email_address', 'E-mail address')}
value="[email protected]"
background="gray5"
/>
</Row>
<Row width="50%">
<Input label="Account Name" value="New External Account 1" background="gray5" />
<Input
label={t('label.account_name', 'Account Name')}
value="New External Account 1"
background="gray5"
/>
</Row>
</Row>
<Row
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ const PersonaUseSection = ({
>
<Row width="50%" padding={{ right: 'small' }}>
<ChipInput
label="e.g. Bob Smith"
label={t('label.reply_to_field_example', "e.g. Bob Smith")}
value=""
placeholder={t('label.folders', 'Folders')}
background="gray5"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const ModuleVersionSettings: FC = () => {
<Text>
{app.display} ({app.name})
</Text>
<Tooltip placement="top" label="Click to copy">
<Tooltip placement="top" label={t('label.click_to_copy', 'Click to copy')}>
<Text style={{ cursor: 'pointer' }} onClick={(e: any): any => copyToClipboard(e)}>
Version: {app.version}
</Text>
Expand Down
14 changes: 9 additions & 5 deletions src/ui-extras/spinner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@

import React, { FC } from 'react';
import { Button, Container } from '@zextras/carbonio-design-system';
import { useTranslation } from 'react-i18next';

export const Spinner: FC = () => (
<Container width="fill" height="fill" mainAlignment="center" crossAlignment="center">
<Button type="ghost" label="Button" color="primary" loading />
</Container>
);
export const Spinner: FC = () => {
const [t] = useTranslation();
return (
<Container width="fill" height="fill" mainAlignment="center" crossAlignment="center">
<Button type="ghost" label={t('button', 'Button')} color="primary" loading />
</Container>
);
};
Loading

0 comments on commit b27113f

Please sign in to comment.