fix: change how the fonts are imported and bundled #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import fonts directly so that rollup is able to recognize them and bundle with the url-plugin as inline resources. By bundling them this way, fonts are resolved and used when setting the loadDefaultFont prop in the ThemeProvider. Update also webpack to recognize the fonts as asset/resource for the styleguide. Add a file transformer for jest and update the config to use it. Remove no more used plugin from dependencies. refs: CDS-110
For other components of the documentation (list, title, field description, etc) use the sans-serif. Define styleguide theme config in an external file to make them hot-reloadable refs: CDS-110
beawar
requested review from
nubsthead,
giuliano176,
dhavaldodiya,
CataldoMazzilli,
lisaparma,
CerDennis,
gnekoz and
FrancescoGottardi
as code owners
beawar
changed the title
nubsthead
previously approved these changes
Jan 12, 2023
|
There is something wrong at runtime, back to draft |
Rollup v3 has some breaking changes which require a more in depth investigation Use @rollup/plugin-url instead of rollup-plugin-url refs: CDS-110
nubsthead
approved these changes
Jan 13, 2023
giuliano176
approved these changes
Jan 16, 2023
CataldoMazzilli
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: change how the fonts are imported and bundled
730fb0e
Import fonts directly so that rollup is able to recognize them
and bundle with the url-plugin as inline resources.
By bundling them this way, fonts are resolved and used when setting
the loadDefaultFont prop in the ThemeProvider.
Update also webpack to recognize the fonts as asset/resource for the styleguide.
Add a file transformer for jest and update the config to use it.
Remove no more used plugin from dependencies.
refs: CDS-110
docs: use default fonts for docs examples
160e6b0
For other components of the documentation (list, title, field description, etc)
use the sans-serif.
Define styleguide theme config in an external file to make them hot-reloadable
refs: CDS-110