fix: if we delete contact permanently, we see delete address book but…

…ton (#250) * fix: if we delete contact permanently, we see delete address book button
zextras · Aug 21, 2024 · ff4878c · ff4878c
1 parent 7ff1d87
commit ff4878c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/src/actions/delete-contacts.test.tsx b/src/actions/delete-contacts.test.tsx
@@ -21,7 +21,7 @@ describe("Delete-contacts' actions", () => {
 		expect(result.current).toEqual<UIAction<unknown, unknown>>(
 			expect.objectContaining({
 				icon: 'DeletePermanentlyOutline',
-				label: 'Delete contacts permanently',
+				label: 'Delete contact permanently',
 				id: 'delete-contacts-action'
 			})
 		);
@@ -65,6 +65,6 @@ describe('execute actions', () => {
 		populateFoldersStore();
 		const { result } = setupHook(useActionDeleteContacts);
 		const action = result.current;
-		expect(action.label).toBe('Delete contacts permanently');
+		expect(action.label).toBe('Delete contact permanently');
 	});
 });
diff --git a/src/actions/delete-contacts.tsx b/src/actions/delete-contacts.tsx
@@ -61,7 +61,7 @@ export const useActionDeleteContacts = (): ActionDeleteContacts => {
 	return useMemo(
 		() => ({
 			id: ACTION_IDS.deleteContacts,
-			label: t('folder.action.delete_permanently', 'Delete contacts permanently'),
+			label: t('tooltip.list_trash.deletePermanently', 'Delete contact permanently'),
 			icon: 'DeletePermanentlyOutline',
 			execute,
 			canExecute

diff --git a/src/constants/tests.ts b/src/constants/tests.ts
@@ -64,7 +64,7 @@ export const CONTACT_ACTIONS_DESCRIPTORS = {
 	},
 	deletePermanently: {
 		id: 'deletePermanently',
-		desc: 'Delete contacts permanently',
+		desc: 'Delete contact permanently',
 		icon: 'DeletePermanentlyOutline'
 	},
 	delete: {

diff --git a/src/legacy/views/folder/list-item-action-wrapper.jsx b/src/legacy/views/folder/list-item-action-wrapper.jsx
@@ -17,7 +17,7 @@ const HoverBarContainer = styled(Container)`
 	display: none;
 	position: absolute;
 	background: linear-gradient(to right, transparent, ${({ theme }) => theme.palette.gray6.hover});
-	height: 45%;
+	height: 55%;
 	& > * {
 		margin-top: ${({ theme }) => theme.sizes.padding.small};
 		margin-right: ${({ theme }) => theme.sizes.padding.small};

diff --git a/src/legacy/views/preview/contact-preview-content.jsx b/src/legacy/views/preview/contact-preview-content.jsx
@@ -373,8 +373,9 @@ function ContactPreviewContent({ contact, onEdit, onDelete, onMail, onMove }) {
 						{showTagIcon && (
 							<Padding left="small">
 								<Tooltip label={singleTagLabel} disabled={showMultiTagIcon}>
-									<IconButton
+									<Button
 										data-testid="TagIcon"
+										type="ghost"
 										size="large"
 										onClick={onTagClick}
 										icon={tagIcon}
@@ -409,7 +410,7 @@ function ContactPreviewContent({ contact, onEdit, onDelete, onMail, onMove }) {
 						<Tooltip
 							label={
 								isTrash(contact.parent)
-									? t('folder.action.delete_permanently', 'Delete contacts permanently')
+									? t('tooltip.list_trash.deletePermanently', 'Delete contact permanently')
 									: t('label.delete', 'Delete')
 							}
 						>