revert: [CO-1616] undo editor attendees changes introduced in react-18 migrations #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we should approach the typing issue by adding some tests. Seems ChipItem and EditorAttachment are incompatible. We noticed the ContactInput is broken while doing manual tests
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: carbonio-calendars-ui |
frisonisland
changed the title
frisonisland
changed the title
frisonisland
requested review from
nubsthead,
keshavbhatt and
FrancescoGottardi
keshavbhatt
approved these changes
Nov 6, 2024
FrancescoGottardi
approved these changes
Nov 6, 2024
nubsthead
pushed a commit
that referenced
this pull request
Nov 15, 2024
- we should approach the typing issue by adding some tests. Seems ChipItem and EditorAttachment are incompatible. We noticed the ContactInput is broken while doing manual tests
frisonisland
added a commit
that referenced
this pull request
Nov 18, 2024
- we should approach the typing issue by adding some tests. Seems ChipItem and EditorAttachment are incompatible. We noticed the ContactInput is broken while doing manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should approach the typing issue by adding some tests. Seems ChipItem and EditorAttachment are incompatible.
We noticed the ContactInput is broken while doing manual tests: when you add a new attendee the it clears all other attendees, resulting in only one attendee to be present