Update VERSION in Makefile and add documentation for string_view_t #641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information to the docs about
PUGIXML_STRING_VIEW
,PUGIXML_HAS_STRING_VIEW
,string_view_t
and the overloads that use it. Attempted to have the documentation be future-leaning by primarily documenting the (permanent)PUGIXML_HAS_STRING_VIEW
define and only mentioningPUGIXML_STRING_VIEW
as a note in the documentation forPUGIXML_HAS_STRING_VIEW
.Docs generated with newer version of asciidoctor 2.0.23 which seems to have also moved some of the css around, though I have not noticed a visual difference.
The
VERSION
variable in the Makefile was accidentally broken in a previous commit by adding the word "version" to pugixmlconfig.hpp. This is the output of the sed command used to defineVERSION
The result of the old sed command:
which caused this behavior when trying to build docs
Tweaked the sed command to /q quit after the first occurance of the word "version" to handle this case.
Related: #626