Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeta ABI #2

Merged
merged 22 commits into from
Feb 21, 2023
Merged

Zeta ABI #2

merged 22 commits into from
Feb 21, 2023

Conversation

konrads
Copy link
Contributor

@konrads konrads commented Feb 20, 2023

No description provided.

@konrads konrads requested a review from xjcaa February 20, 2023 03:01
src/lib.rs Outdated
@@ -108,4 +113,12 @@ mod zeta {
pub(crate) fn liquidate(ctx: Context<Liquidate>, size: u64) -> Result<()> {
Ok(())
}

pub fn close_open_orders(ctx: Context<CloseOpenOrders>, _map_nonce: u8) -> Result<()> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also be (crate)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

src/account.rs Outdated
pub perp_parameters: PerpParameters, // 24
pub perp_sync_queue: Pubkey, // 32
pub oracle_backup_feed: Pubkey, // 32
pub padding: [u8; 966], // 966
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be updated to the latest - it's slightly out of date, theres a few fields like

perpOnly, flexUnderlying

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

pub enum Asset {
SOL = 0,
BTC = 1,
ETH = 2,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres one more APT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

@xjcaa xjcaa changed the title Refresh as per 01-01-23 Zeta ABI Feb 20, 2023
src/account.rs Outdated
Ok(())
}

pub fn reset(&mut self) -> Result<()> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set, reset, don't need to be in here, along with the errors

src/account.rs Outdated
&zeta_group.margin_parameters,
);

msg!(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably remove this log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@xjcaa xjcaa self-requested a review February 20, 2023 09:51
Copy link

@xjcaa xjcaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just the comments i've left which should be easy to fix

could you add to changelog

@konrads konrads merged commit 42cbde9 into master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants