Remove 151 from blockheight check (#425)

zetamarkets · Nov 12, 2024 · 10efca4 · 10efca4
1 parent e31acc4
commit 10efca4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 Version changes are pinned to SDK releases.
 
+## [1.50.0]
+
+- Remove -151 magic number from blockhash confirmation ([#425](https://github.com/zetamarkets/sdk/pull/425))
+
 ## [1.49.0]
 
 - New asset GOAT. ([#422](https://github.com/zetamarkets/sdk/pull/423))

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@zetamarkets/sdk",
   "repository": "https://github.com/zetamarkets/sdk/",
-  "version": "1.49.0",
+  "version": "1.50.0",
   "description": "Zeta SDK",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/utils.ts b/src/utils.ts
@@ -1373,10 +1373,9 @@ export async function processVersionedTransaction(
       let currentBlockHeight = 0;
       if (!Exchange.skipRpcConfirmation) {
         let resendCounter = 0;
-        // https://solana.com/docs/advanced/confirmation#how-does-transaction-expiration-work
         while (
           currentBlockHeight <
-          recentBlockhash.lastValidBlockHeight - 151
+          recentBlockhash.lastValidBlockHeight
         ) {
           // Keep resending to maximise the chance of confirmation
           resendCounter += 1;
@@ -1566,10 +1565,9 @@ export async function processTransaction(
       let currentBlockHeight = 0;
       if (!Exchange.skipRpcConfirmation) {
         let resendCounter = 0;
-        // https://solana.com/docs/advanced/confirmation#how-does-transaction-expiration-work
         while (
           currentBlockHeight <
-          recentBlockhash.lastValidBlockHeight - 151
+          recentBlockhash.lastValidBlockHeight
         ) {
           // Keep resending to maximise the chance of confirmation
           resendCounter += 1;