feat(gateway): improve Gateway contract #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift1337
force-pushed
the
feat/batch-improvements
branch
from
de845d7 to
f2c3b17
Compare
swift1337
requested review from
lumtis,
fbac,
skosito,
ws4charlie and
brewmaster012
lumtis
reviewed
Oct 8, 2024
lumtis
reviewed
Oct 8, 2024
This was
linked to
issues
Oct 8, 2024
lumtis
approved these changes
Oct 10, 2024
skosito
approved these changes
Oct 10, 2024
| @@ -216,14 +209,20 @@ export class Gateway implements Contract { | |||
| return state.balance; | |||
| } | |||
|
|
|||
| async getQueryState(provider: ContractProvider): Promise<[boolean, bigint, string]> { | |||
| async getGatewayState(provider: ContractProvider): Promise<GatewayState> { | |||
There was a problem hiding this comment.
nit, can be called getState since gateway.getGatewayState seems redundant, but up to you
There was a problem hiding this comment.
Actually, getState() is reserved by TON which returns TON balance and last tx hash thus I chose this name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
authorityconcept. Move the following messages from TSS to authorityset_deposits_enabledupdate_codeupdate_tssupdate_authoritymessageCloses #5, #11, #13, #14