-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hardcode erc20 asset strings to align with the data in foreign coin store #3273
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
added Github issue link above hardcoded variable Co-authored-by: Lucas Bertrand <[email protected]>
added Github issue link around the hotfix Co-authored-by: Lucas Bertrand <[email protected]>
added Github issue link around the hotfix Co-authored-by: Lucas Bertrand <[email protected]>
add Github issue at the hotfix Co-authored-by: Lucas Bertrand <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v23 #3273 +/- ##
===============================================
- Coverage 62.72% 62.70% -0.02%
===============================================
Files 424 424
Lines 30298 30322 +24
===============================================
+ Hits 19004 19014 +10
- Misses 10452 10466 +14
Partials 842 842
|
Description
ERC20 deposits were not well observed in BSC, Polygon. These were caused by foreign coin asset mismatch in the
MsgVoteInbound
. See:BSC failed vote: https://explorer.zetachain.com/cosmos/tx/5F81D3F623B57E64FBF4ADE684C778BF83ACA8AC059A86B7D2273908930A2022
Polygon failed vote: https://explorer.zetachain.com/cosmos/tx/1C54E4CAFBE226B17E82D838291DF65EF51EE07EDCFD2B7DDE39EA735E7FAC67
Solution:
Taking the list of foreign ERC20 tokens, and hardcoded the mapping
ERC20 address --> asset
so that zetaclients can use the correct asset string in their inbound ERC20 votes.How Has This Been Tested?