Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardcode erc20 asset strings to align with the data in foreign coin store #3273

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

ws4charlie
Copy link
Contributor

Description

ERC20 deposits were not well observed in BSC, Polygon. These were caused by foreign coin asset mismatch in the MsgVoteInbound. See:

BSC failed vote: https://explorer.zetachain.com/cosmos/tx/5F81D3F623B57E64FBF4ADE684C778BF83ACA8AC059A86B7D2273908930A2022
Polygon failed vote: https://explorer.zetachain.com/cosmos/tx/1C54E4CAFBE226B17E82D838291DF65EF51EE07EDCFD2B7DDE39EA735E7FAC67

Solution:
Taking the list of foreign ERC20 tokens, and hardcoded the mapping ERC20 address --> asset so that zetaclients can use the correct asset string in their inbound ERC20 votes.

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

@ws4charlie ws4charlie marked this pull request as ready for review December 10, 2024 20:56
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

zetaclient/chains/evm/observer/inbound.go Show resolved Hide resolved
zetaclient/chains/evm/observer/inbound.go Outdated Show resolved Hide resolved
zetaclient/chains/evm/observer/inbound.go Outdated Show resolved Hide resolved
zetaclient/chains/evm/observer/v2_inbound.go Outdated Show resolved Hide resolved
zetaclient/chains/evm/observer/inbound.go Outdated Show resolved Hide resolved
zetaclient/chains/evm/observer/inbound.go Outdated Show resolved Hide resolved
zetaclient/chains/evm/observer/inbound.go Outdated Show resolved Hide resolved
zetaclient/chains/evm/observer/inbound.go Outdated Show resolved Hide resolved
zetaclient/chains/evm/observer/v2_inbound.go Outdated Show resolved Hide resolved
added Github issue link above hardcoded variable

Co-authored-by: Lucas Bertrand <[email protected]>
ws4charlie and others added 5 commits December 10, 2024 15:28
added Github issue link around the hotfix

Co-authored-by: Lucas Bertrand <[email protected]>
added Github issue link around the hotfix

Co-authored-by: Lucas Bertrand <[email protected]>
add Github issue at the hotfix

Co-authored-by: Lucas Bertrand <[email protected]>
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.

Project coverage is 62.70%. Comparing base (ff5d8e3) to head (e4eecdf).
Report is 1 commits behind head on release/v23.

Files with missing lines Patch % Lines
zetaclient/chains/evm/observer/v2_inbound.go 0.00% 14 Missing ⚠️
zetaclient/chains/evm/observer/inbound.go 86.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/v23    #3273      +/-   ##
===============================================
- Coverage        62.72%   62.70%   -0.02%     
===============================================
  Files              424      424              
  Lines            30298    30322      +24     
===============================================
+ Hits             19004    19014      +10     
- Misses           10452    10466      +14     
  Partials           842      842              
Files with missing lines Coverage Δ
zetaclient/chains/evm/observer/inbound.go 35.46% <86.66%> (+0.91%) ⬆️
zetaclient/chains/evm/observer/v2_inbound.go 0.00% <0.00%> (ø)

@ws4charlie ws4charlie merged commit 2ca464a into release/v23 Dec 10, 2024
38 of 40 checks passed
@ws4charlie ws4charlie deleted the fix-erc20-asset-checksum-mismatch branch December 10, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants