prevent hiding smart contract error

zeta-chain · Nov 27, 2024 · c35c086 · c35c086
1 parent 8d5caac
commit c35c086
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/x/crosschain/keeper/cctx_orchestrator_validate_outbound.go b/x/crosschain/keeper/cctx_orchestrator_validate_outbound.go
@@ -240,7 +240,7 @@ func (k Keeper) processSuccessfulOutbound(
 	oldStatus := cctx.CctxStatus.Status
 	switch oldStatus {
 	case types.CctxStatus_PendingRevert:
-		cctx.SetReverted("", "revert executed")
+		cctx.SetReverted("", "")
 	case types.CctxStatus_PendingOutbound:
 		cctx.SetOutboundMined("")
 	default:

diff --git a/x/crosschain/types/status.go b/x/crosschain/types/status.go
@@ -13,7 +13,8 @@ func (m *Status) AbortRefunded() {
 func (m *Status) UpdateStatusAndErrorMessages(newStatus CctxStatus, statusMsg, errorMsg string) {
 	m.UpdateStatus(newStatus, statusMsg)
 
-	if newStatus == CctxStatus_Aborted || newStatus == CctxStatus_Reverted || newStatus == CctxStatus_PendingRevert {
+	if errorMsg != "" &&
+		(newStatus == CctxStatus_Aborted || newStatus == CctxStatus_Reverted || newStatus == CctxStatus_PendingRevert) {
 		m.UpdateErrorMessage(errorMsg)
 	}
 }