Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwin1 #265

Merged
merged 9 commits into from
Mar 23, 2022
Merged

Darwin1 #265

merged 9 commits into from
Mar 23, 2022

Conversation

darwin808
Copy link
Contributor

-fixes in dark mode css
-Please refer to commit messages

Copy link
Collaborator

@giseleblair giseleblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In component FullScreenHeroWithPromoImagesAndTypedText  where are “slantedImages” coming from? I can’t find the field with an array of images. The content model only has one image in the header_image field: https://8-aaeffee09b-7w6v22.manager.zesty.io/content/6-bea29b8bc7-163xd7/7-fefc9fa3cb-xbbj5g

In the component WYSIWYGRender the styles need to be coming from the content. Please don’t add styles to the p child elements.

@darwin808
Copy link
Contributor Author

In component FullScreenHeroWithPromoImagesAndTypedText where are “slantedImages” coming from? I can’t find the field with an array of images. The content model only has one image in the header_image field: https://8-aaeffee09b-7w6v22.manager.zesty.io/content/6-bea29b8bc7-163xd7/7-fefc9fa3cb-xbbj5g

-it is from the solutions page the array of images

Screenshot_2022-03-23_20-02-55

In the component WYSIWYGRender the styles need to be coming from the content. Please don’t add styles to the p child elements.

Screenshot_2022-03-23_20-18-42

-they are all p tags from cms per line , I cant distinguish which element to target , maybe we can change the "CMS is boring " to another element instead of p tag?

@ardeay ardeay merged commit c451c08 into main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants