Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm64 Support for Windows #1728

Closed
wants to merge 3 commits into from
Closed

Conversation

chenx-dust
Copy link

It works well now on my Surface Pro X.

@chenx-dust
Copy link
Author

chenx-dust commented Jul 27, 2022

Some important information should be declared:
I found some buiding problems in the module zeroidc, when using --target=aarch64-pc-windows-msvc on my amd64 computer. I spotted that it was caused by an upstream module ring, which doesn't work properly at the version 0.16.20.
Therefore, I try to update it to the github version of it. The non-released 0.17 version works well, but the new one is incompatible with other modules😂. Thus, the only thing I could do was to use the patch feature of cargo, which might, however, cause some unexpectable problems when other modules update. Anyway, it works now😊.

Some code refes to briansmith/ring@ceb5b90

@conioh
Copy link

conioh commented Aug 14, 2022

I would like it very much to see this get into the product.

@dmkjr
Copy link

dmkjr commented Sep 25, 2022

This is interesting. Any movement on getting it added?

@hoamle
Copy link

hoamle commented Jan 3, 2023

Would love to see this get reviewed and merged as well!

@someara someara deleted the branch zerotier:master January 6, 2023 14:34
@someara someara closed this Jan 6, 2023
@conioh
Copy link

conioh commented Jan 7, 2023

Sad.

@chenx-dust
Copy link
Author

Sad.

Well, I guess the reason why this pr was closed might be I wrongly chose to merge it into the master branch, which should be dev branch. I can open a new pr, but I'm sorry that I've sold my Surface Pro X, thus making it impossible for me to test whether the code works. So I hope someone who is interested in this work to pull request.

@someara
Copy link
Contributor

someara commented Jan 7, 2023

Hello!

Sorry about that. I was doing some maintenance for our Github organization, trying to normalize all the branch names, and settings.... this was automatically closed when I deleted the master branch.

Please re-open against dev... I'll work on getting some Windows builds into CI for this.

-s

@chenx-dust
Copy link
Author

Hello!

Sorry about that. I was doing some maintenance for our Github organization, trying to normalize all the branch names, and settings.... this was automatically closed when I deleted the master branch.

Please re-open against dev... I'll work on getting some Windows builds into CI for this.

-s

Never mind. I've opened a new one. #1837

@someara
Copy link
Contributor

someara commented Jan 7, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants