chore: minor correction in required CMake #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum require version of CMake for scikit-build-core is 3.15, so setting it below 3.15 isn't helpful.
|
Thanks! I'd like to require a more recent version! But I encountered some failures when cmake isn't available as a wheel, so wanted to be conservative and accept most versions that are out there. My needs are pretty basic beyond FetchContent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum require version of CMake for scikit-build-core is 3.15, so setting it below 3.15 isn't helpful.
It could be removed altogether, as the default it to require what scikit-build-core requires, but leaving it here might make it easier to update on your end if you decide to raise it someday (3.26 is really nice!)