Problem: libzmq uses API not documented on learn.microsoft.com #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: use WaitOnAddress instead of KeyedEvents APIs
rzhao271
force-pushed
the
rzhao271/use-wait
branch
from
9fed16b to
8bf5e71
Compare
|
wepoll is imported from https://github.com/piscisaureus/wepoll please send changes there |
|
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Use WaitOnAddress instead of KeyedEvents APIs
This PR would help Microsoft repositories consuming libzmq and zeromq.js (such as microsoft/zeromq-prebuilt) to get into compliance with internal policies. I have created a PR here to request feedback on my changes and start a discussion on whether these changes could be integrated into this repository.