Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Add features to linux gradle, update readme to match #114

Closed
wants to merge 39 commits into from

Conversation

5HT2
Copy link
Contributor

@5HT2 5HT2 commented Aug 7, 2019

No description provided.

@zeroeightysix
Copy link
Owner

Can you put the new tasks into a group kami?

task myTask() {
    group = "kami"
    ...
}

And please remove testprint

@5HT2
Copy link
Contributor Author

5HT2 commented Aug 7, 2019

Forgot testprint, and just a sec on groups thanks

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@leijurv
Copy link

leijurv commented Aug 9, 2019

hey not everyone is ~/.minecraft/

on mac osx it's ~/Library/Application Support/minecraft/

@nothub
Copy link
Contributor

nothub commented Aug 9, 2019

An easy fix for compatibility would be checking $OSTYPE, also support for MultiMC would be awesome :3 Testing for a set env variable like $KAMI_DIR.

@5HT2
Copy link
Contributor Author

5HT2 commented Aug 10, 2019

I have compatibility down, MultiMC with would have to be another check but it's possible. I'm not sure MultiMC sets env variables, especially not on stuff other then Linux

@5HT2
Copy link
Contributor Author

5HT2 commented Oct 5, 2019

I'm not sure how to check, does this pull include my gradlew and the windows changes? (Follow this to see all differences).
If it does, you can force the pull and replace my readme with yours. The only changes I made that you can't keep is adding you to thank yous, and adding my issues button in the readme.

Edit: oop my SetCommand.java is outdated, I'll go and fix those manually. Let me know if I miss any

@5HT2
Copy link
Contributor Author

5HT2 commented Oct 5, 2019

The command is the other way around. Open this with the diff syntax in sublime. + is stuff I added
diff.txt

@5HT2 5HT2 requested a review from zeroeightysix October 6, 2019 13:56
@5HT2
Copy link
Contributor Author

5HT2 commented Oct 6, 2019

On line 38 in commit posVec is still using Vector, is this fine @zeroeightysix?
I'm not sure who made the change to stop using it, I'm just confirming because I'm readding all of the changes between my repo and yours

@5HT2
Copy link
Contributor Author

5HT2 commented Oct 15, 2019

I will keep the suggestions as reference, though due to this drifting too far from 086's version I will manually reimplement everything and continue the project. Thanks for all of your hard work everybody.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants