Update changelog for 3.7.10 release #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
reviewed
Oct 24, 2023
Co-authored-by: Joe George <[email protected]>
Co-authored-by: Joe George <[email protected]>
Co-authored-by: Joe George <[email protected]>
Co-authored-by: Joe George <[email protected]>
CHANGELOG-3.7.md
Outdated
|
|
||
| ## C# Changes | ||
|
|
||
| - Fix generated code for compatability with .NET 8. (https://github.com/zeroc-ice/ice/issues/1548) |
There was a problem hiding this comment.
Looking at the rest of the changelog, we always write these in past-tense:
Suggested change
| - Fix generated code for compatability with .NET 8. (https://github.com/zeroc-ice/ice/issues/1548) | |
| - Fixed generated code to be compatible with .NET 8. (https://github.com/zeroc-ice/ice/issues/1548) |
CHANGELOG-3.7.md
Outdated
|
|
||
| ## Python Changes | ||
|
|
||
| - Fix Python 3.12 build failures https://github.com/zeroc-ice/ice/issues/1558 |
There was a problem hiding this comment.
Suggested change
| - Fix Python 3.12 build failures https://github.com/zeroc-ice/ice/issues/1558 | |
| - Fixed Python 3.12 build failures. (https://github.com/zeroc-ice/ice/issues/1558) |
CHANGELOG-3.7.md
Outdated
|
|
||
| - Build fixes for compatibility with JDK 21 | ||
|
|
||
| - Fix generated Java constructors to correctly count the max parameters https://github.com/zeroc-ice/ice/issues/1540 |
There was a problem hiding this comment.
Suggested change
| - Fix generated Java constructors to correctly count the max parameters https://github.com/zeroc-ice/ice/issues/1540 | |
| - Fixed generated Java constructors to correctly count the max parameters. (https://github.com/zeroc-ice/ice/issues/1540) |
CHANGELOG-3.7.md
Outdated
|
|
||
| - Fixed failures building from source with G++ 13. (https://github.com/zeroc-ice/ice/issues/1489) | ||
|
|
||
| - Fixed the C++11 library names produced by Windows builds. (https://github.com/zeroc-ice/ice/issues/1502) |
There was a problem hiding this comment.
I would remove this entry. It's a minor change, and as stated, confusing.
CHANGELOG-3.7.md
Outdated
|
|
||
| ## C# Changes | ||
|
|
||
| - Fixed generated code for compatability with .NET 8. (https://github.com/zeroc-ice/ice/issues/1548) |
There was a problem hiding this comment.
compatibility ... .NET 8.0
CHANGELOG-3.7.md
Outdated
|
|
||
| - Add support for JDK 21. | ||
|
|
||
| - Fixed generated Java constructors to correctly count the max parameters. (https://github.com/zeroc-ice/ice/issues/1540) |
There was a problem hiding this comment.
Should be rephrased. It's about not generating these constructors in some cases.
InsertCreativityHere
approved these changes
Oct 24, 2023
CHANGELOG-3.7.md
Outdated
|
|
||
| ## Java Changes | ||
|
|
||
| - Add support for JDK 21. |
There was a problem hiding this comment.
For consistency with the rest of the file:
Suggested change
| - Add support for JDK 21. | |
| - Added support for JDK 21. |
We always say "added support for X".
CHANGELOG-3.7.md
Outdated
|
|
||
| ## Python Changes | ||
|
|
||
| - Add support for Python 3.12. (https://github.com/zeroc-ice/ice/issues/1558) |
There was a problem hiding this comment.
Same
Suggested change
| - Add support for Python 3.12. (https://github.com/zeroc-ice/ice/issues/1558) | |
| - Added support for Python 3.12. (https://github.com/zeroc-ice/ice/issues/1558) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.