Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ice.ServerIdleTime in tests #2025

Closed
bernardnormier opened this issue Apr 4, 2024 · 1 comment · Fixed by #2041
Closed

Ice.ServerIdleTime in tests #2025

bernardnormier opened this issue Apr 4, 2024 · 1 comment · Fixed by #2041
Assignees
@externl
Labels
cleanup testsuite
Milestone
3.8.0

Comments

@bernardnormier
Copy link
Member

A number of tests configure Ice.ServerIdleTime, however, it's not clear why they do it and no test appears to actually verify that Ice.ServerIdleTime works.

Keep in the mind the default value for Ice.ServerIdleTime is 0 - meaning, the communicator is not shutdown automatically when inactive.
@bernardnormier bernardnormier added this to the 3.8.0 milestone Apr 4, 2024
@externl externl self-assigned this Apr 10, 2024
externl added a commit to externl/ice that referenced this issue Apr 10, 2024
@externl
Ice.ServerIdleTime test fixes
7bd053c 
Closes zeroc-ice#2025
@externl externl mentioned this issue Apr 10, 2024
Merged
externl added a commit that referenced this issue Apr 11, 2024
@externl
Ice.ServerIdleTime test fixes (#2041)
05fbaef 
- Remove the random usage in the tests
- Adds a test to exercise Ice.ServerIdleTime
- Fix a few selector bugs

Closes #2025
pepone pushed a commit to pepone/ice that referenced this issue Apr 12, 2024
@externl @pepone
Ice.ServerIdleTime test fixes (zeroc-ice#2041)
d019955 
- Remove the random usage in the tests
- Adds a test to exercise Ice.ServerIdleTime
- Fix a few selector bugs

Closes zeroc-ice#2025
@externl
Copy link
Member

externl commented Apr 15, 2024 •
edited
Loading

When implementing this I also found several issues which affected primarily Apple platforms.

  1. The idle time was multiplied by a factor of 1000 on platforms using kqueue (Primarily macOS, also BSD).
  2. iOS servers would never become idle.

externl added a commit to externl/ice that referenced this issue Apr 15, 2024
@externl
Ice.ServerIdleTime fixes
5c1047d 
See zeroc-ice#2025
@externl externl mentioned this issue Apr 15, 2024
Merged
externl added a commit that referenced this issue Apr 15, 2024
@externl
Ice.ServerIdleTime fixes (#2049)
030a337 
See #2025
InsertCreativityHere pushed a commit to InsertCreativityHere/compiler-comparison that referenced this issue Jan 1, 2025
@externl
HEAD:(zeroc-ice/ice@05fbaef935) Ice.ServerIdleTime test fixes (zeroc-…
643f050 
…ice/ice#2041)

- Remove the random usage in the tests
- Adds a test to exercise Ice.ServerIdleTime
- Fix a few selector bugs

Closes zeroc-ice/ice#2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@externl externl

Labels
cleanup testsuite
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Ice.ServerIdleTime test fixes externl/ice
2 participants
@externl @bernardnormier