Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken default parameter in PHP createProperties() #1384

Closed
tirmog opened this issue Jul 20, 2022 · 2 comments · Fixed by #1386
Closed

broken default parameter in PHP createProperties() #1384

tirmog opened this issue Jul 20, 2022 · 2 comments · Fixed by #1386
Assignees
Labels
Milestone

Comments

@tirmog
Copy link

tirmog commented Jul 20, 2022

We recently upgraded to ice-php-3.7.7 (from 3.7.1), due to needing to support php-8.1 in the very near future.
However, we ran into:

Warning: Ice\\createProperties() expects at least 1 parameter, 0 given in ...

Looks like it no longer defaults to empty array for the parameter?

@tirmog
Copy link
Author

tirmog commented Jul 20, 2022

Looks like maybe the argument to zend_parse_parameters got changed inadvertently?
OLD (3.7.1): const_cast<char*>("|a!O!")
NEW (3.7.7): const_cast<char*>("|a!|O!")
(note the extra pipe)

@pepone
Copy link
Member

pepone commented Jul 20, 2022

Thanks @tirmog, I may be able to squeeze a fix before the upcoming 3.7.8 release

@pepone pepone added the bug label Jul 20, 2022
@pepone pepone self-assigned this Jul 20, 2022
@pepone pepone added this to the 3.7.8 milestone Jul 20, 2022
pepone added a commit to pepone/ice that referenced this issue Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants