Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joomla-cms] [PR 30748] Add update SQL scripts 4.0.0-2020-09-27.sql #47

Conversation

richard67
Copy link

Pull Request for joomla#30748.

Summary of Changes

Add new update SQL script to delete the plugin from the extensions table.

Testing Instructions

Important: The testing instructions of PR joomla#30748 should be extended by this test here.

  1. On a clean 4.0-dev or 4.0 Beta 4 or latest 4.0 nightly installation, update to the update package built by Drone for this PR. The link "Details" can be find at the bottom of the PR in the test section for the test "Package" at the right hand side. There you can find an update package and a custom update URL.

  2. Verify that the update suceeds without SQL errors.

  3. Check in the list of plugins in backend that the plugin can't be found anymore.

Actual result BEFORE applying this Pull Request

Plugin still in the list after update.

Expected result AFTER applying this Pull Request

Plugin not in the list anymore.

Documentation Changes Required

No.

@zero-24 zero-24 merged commit e735059 into zero-24:pluginless_lazyloading Sep 27, 2020
@richard67 richard67 deleted the zero-24-pluginless-lazyloading-new-update-sql branch September 27, 2020 19:50
zero-24 added a commit that referenced this pull request Sep 29, 2020
* remove the plugin code

* make sure there is no error message on attributs passed as string

* implement width & height into the media field

* add width & hight to com_media

* add width & height to the file list

* fix file path

* add width & heigth to the media field

* there is no alt text comming from com_media yet

* patch JS thanks @dgrammatiko

* Update installation/sql/postgresql/base.sql

Co-authored-by: Quy <[email protected]>

* Update installation/sql/mysql/base.sql

Co-authored-by: Quy <[email protected]>

* fix issues mention vy @dgrammatiko and implement width and heigth in the intro and full image layout

* When we have no image nothing is going to be displayed

* move json_decode & change back to the original image url

* take off px for width and height

* reset other changes that has been moved to joomla#30784

* also reset the image list layout

* Update libraries/src/HTML/HTMLHelper.php

* Add update SQL scripts 4.0.0-2020-09-27.sql (#47)

Co-authored-by: Quy <[email protected]>
Co-authored-by: Richard Fath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants