2 to 1 loop optimization in plugins/search/categories/categories.php (j…

…oomla#13390)

* Another lonely `for` to `foreach`modification...

* Too much code for today... not seing the obvious... 😄

* Implementing a good catch by @andrepereiradasilva

* Optimized loop further

plugins/search/categories/categories.php

@@ -184,19 +184,15 @@ public function onContentSearch($text, $phrase = '', $ordering = '', $areas = nu
 
 		if ($rows)
 		{
-			$count = count($rows);
-
-			for ($i = 0; $i < $count; $i++)
+			foreach ($rows as $i => $row)
 			{
-				$rows[$i]->href = ContentHelperRoute::getCategoryRoute($rows[$i]->slug);
-				$rows[$i]->section = JText::_('JCATEGORY');
-			}
 
-			foreach ($rows as $category)
-			{
-				if (searchHelper::checkNoHtml($category, $searchText, array('name', 'title', 'text')))
+				if (searchHelper::checkNoHtml($row, $searchText, array('name', 'title', 'text')))
 				{
-					$return[] = $category;
+					$row->href = ContentHelperRoute::getCategoryRoute($row->slug);
+					$row->section = JText::_('JCATEGORY');
+
+					$return[] = $row;
 				}
 			}
 		}