This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Integrate simple project into CLI #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
feature/lightweight-cli-#74
branch
from
f329b1e
to
6e0faed
Compare
spalladino
force-pushed
the
feature/lightweight-cli-#74
branch
from
6e0faed
to
120b678
Compare
|
Small comment before reviewing, I'd love to have the CLI working by default and add a |
|
As discussed offline, let's tackle that as a separate issue |
facuspagnuolo
approved these changes
Oct 3, 2018
| @@ -179,9 +163,11 @@ export default class NetworkAppController extends NetworkBaseController { | |||
| return []; | |||
| } | |||
|
|
|||
| const ownedProxies = proxies.filter(proxy => !proxy.admin || proxy.admin === this.appAddress); | |||
| // TODO: If 'from' is not explicitly set, then we need to retrieve it from the set of current accounts | |||
There was a problem hiding this comment.
or fail... can we add an issue to track this?
| this.networkFile.app = { address } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
can we split this into multiple files?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--lightflag to the init command to create a lightweight app using a SimpleProject. Dependency management is to be implemented later.To reviewers: I strongly suggest to review this PR with whitespace diff hidden, and preferrably by-commit.
Depends on #161
Fixes #74