Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Get current sender account if missing from params #168

Closed
spalladino opened this issue Oct 3, 2018 · 1 comment
Closed

Get current sender account if missing from params #168

spalladino opened this issue Oct 3, 2018 · 1 comment

Comments

@spalladino
Copy link
Contributor

We have a few checks on the owner of both proxies and App contracts, to validate that the sender account does indeed have rights to perform certain actions. However, if the user does not explicitly set the sender account (via a --from or an entry in truffle.js), we are not checking it.

Add a method to get the sender account from the node (via web3.eth.getAccounts) and cache it, and check against that value when needed.
@spalladino spalladino added this to the Backlog milestone Oct 3, 2018
@spalladino spalladino mentioned this issue Oct 3, 2018
Merged
@facuspagnuolo facuspagnuolo modified the milestones: Backlog, v2.1.0 Nov 26, 2018
@facuspagnuolo facuspagnuolo removed this from the v2.1.0 milestone Jan 8, 2019
@spalladino
Copy link
Contributor Author

Implemented

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spalladino @facuspagnuolo