This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Polish update command files #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
force-pushed
the
polish_update_command_files
branch
3 times, most recently
from
00df357 to
caec2df
Compare
facuspagnuolo
force-pushed
the
polish_update_command_files
branch
from
caec2df to
b7d84c8
Compare
spalladino
approved these changes
Jul 23, 2018
There was a problem hiding this comment.
The PR looks good. However, this is something I wanted to discuss: do we want the command to be named update, given that everywhere we are talking about upgradeability with zOS?
We can also merge this PR now and defer that discussion for later, reverting this commit if needed, if we make that change.
src/commands/update.js
Outdated
| import runWithTruffle from '../utils/runWithTruffle' | ||
| import { parseInit } from '../utils/input' | ||
|
|
||
| const name = 'update' | ||
| const signature = `${name} [alias] [address]` | ||
| const description = 'upgrade contract to a new logic. Provide the [alias] you added your contract with, or use --all flag to upgrade all. If no [address] is provided, all instances of that contract class will be upgraded' | ||
| const description = 'update contract to a new logic. Provide the [alias] you added your contract with, or use --all flag to update all. If no [address] is provided, all instances of that contract class will be upgraded' |
There was a problem hiding this comment.
all instances of that contract class will be updated
|
I really do agree with your opinion, we always talk about |
facuspagnuolo
force-pushed
the
polish_update_command_files
branch
from
b7d84c8 to
8be414e
Compare
spalladino
pushed a commit
to OpenZeppelin/openzeppelin-sdk
that referenced
this pull request
Aug 1, 2018
…te_command_files Polish update command files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update command related files were wrongly named. This PR renames these files (command, scripts and test files). I'm also using update instead of upgrade in many outputted messages