This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Review wording on contract to be removed when running status #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/scripts/status.js
Outdated
| @@ -78,7 +78,7 @@ async function contractsInfo(controller) { | |||
|
|
|||
| // Log contracts in network file missing from package file | |||
| controller.networkFile.contractAliasesMissingFromPackage() | |||
| .forEach(contractAlias => log.warn(`- ${contractAlias} is pending to be removed`)); | |||
| .forEach(contractAlias => log.warn(`- ${contractAlias} is to be removed on next push`)); | |||
There was a problem hiding this comment.
shouldn't this be will be removed on next push?
There was a problem hiding this comment.
I guess both are correct, but will be removed is definitely more clear.
facuspagnuolo
approved these changes
Jul 21, 2018
spalladino
force-pushed
the
fix/status-wording-in-contract-to-be-removed
branch
from
473cb0c to
fe524de
Compare
spalladino
added a commit
to OpenZeppelin/openzeppelin-sdk
that referenced
this pull request
Aug 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304