llext: fix minor Coverity issue #434586 (again) #83757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check combination of "is zero" and then "less than zero" leaves open the theoretical possibility of a positive return value, which would continue on with an uinitialized 'sym'. Checking for "not zero" has the same effect and covers all situations. Commit 56fd854 did the same thing for 'rela' a few lines above, but missed this instance. No other places in the llext code have this issue. Signed-off-by: Luca Burelli <[email protected]>
zephyrbot
added
size: XS
pillo79
added
the
Trivial
teburd
approved these changes
Jan 9, 2025
kartben
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check combination of "is zero" and then "less than zero" leaves open the theoretical possibility of a positive return value, which would continue on with an uinitialized
sym.Checking for "not zero" has the same effect and covers all situations.
Commit 56fd854 did the same thing for
relaa few lines above, but missed this instance.No other places in the llext code have this issue.