drivers: pwm: nrfx: Add idle output to PWM driver #83652
+97
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added clock control api for global hsfll used in fast PWM120 driver. Signed-off-by: Michał Stasiak <[email protected]>
Fast PWM120 prevents GPIO from driving pin with low/high state when PWM duty is 0% or 100%. Idleout feature needs to be used. It can be configured when PWM is disabled and works while it is enabled. Signed-off-by: Michał Stasiak <[email protected]>
mstasiaknordic
force-pushed
the
idleout_pwm
branch
from
6c05f4f to
4ab7a6f
Compare
nika-nordic
approved these changes
Jan 8, 2025
| @@ -234,7 +234,13 @@ static int pwm_nrfx_set_cycles(const struct device *dev, uint32_t channel, | |||
| out_level ^= 1; | |||
| } | |||
|
|
|||
| #if NRF_PWM_HAS_IDLEOUT | |||
| nrfx_pwm_stop(&config->pwm, true); | |||
| nrfy_pwm_channel_idle_set(config->pwm.p_reg, channel, out_level); | |||
There was a problem hiding this comment.
why can't you drive P7 pin directly? because of CTRLSEL==PWM ?
| @@ -234,7 +234,13 @@ static int pwm_nrfx_set_cycles(const struct device *dev, uint32_t channel, | |||
| out_level ^= 1; | |||
| } | |||
|
|
|||
| #if NRF_PWM_HAS_IDLEOUT | |||
| nrfx_pwm_stop(&config->pwm, true); | |||
There was a problem hiding this comment.
isn't the PWM already stopped at this point?
There was a problem hiding this comment.
Not if previous sequence actually used PWM. Moreover, nrfy_pwm_disable is called within irq handler when used with nrfx_pwm_stop(..., false). In this case, using nrfx_pwm_stop(..., true) makes sure that PWM is disabled and driver is set to initialized state before setting the value of idleout, which would normally be ignored.
zephyrbot
requested review from
anangl,
henrikbrixandersen,
jaz1-nordic,
kl-cruz,
magp-nordic and
masz-nordic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast PWM120 prevents GPIO from driving pin with low/high state when PWM duty is 0% or 100%. Idleout feature needs to be used. It can be configured when PWM is disabled and works while it is enabled.
DNM until #82133 is merged. Solution is in the top commit.