Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WPA3 enterprise only mode #83460

Merged

Conversation

MaochenWang1
Copy link
Collaborator

net: wifi: fix wifi connect parameter count error
Fix wrong parameter count error when input 'wifi connect' in enterprise mode.

net: wifi: should enable MFP when connect to WPA3 network
Add check that should enable MFP when connect to WPA3 network.

net: wifi: support printing WPA3 enterprise in scan result
Support printing WPA3 enterprise type in scan result, including the suiteb, suiteb-192 and WPA3 enterprise only.

hostap: support getting enterprise type by status cmd
For 'wifi status' and 'wifi ap status' cmd, support getting the specific enterprise mode, including the WPA3 enterprise mode and the EAP method type.

net: wifi: fix typo of EAP method

hostap: add WPA3 enterprise security type
Change Wi-Fi suiteb type into WPA3 enterprise security type. Support setting WPA3 enterprise only mode, which should use cipher_config->key_mgmt as WPA-EAP-SHA256, and the AKM in RSN IE will show 00-0F-AC:5.

net: l2: wifi: remove EAP TLS SHA256 security
Remove EAP TLS SHA256 security, as it should be replaced by WPA3 enterprise only mode.

Remove EAP TLS SHA256 security, as it was added to support the AKM
of 00-0F-AC:5 in RSN IE, but actually this AKM is used by WPA3
enterprise only mode.

Signed-off-by: Maochen Wang <[email protected]>
@krish2718
Copy link
Collaborator

@MaochenWang1 the description shouldn't be copy-paste of all commit logs, it should have a summary describing the context of the changes (why, what..).

Copy link
Collaborator

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include/zephyr/net/wifi.h Show resolved Hide resolved
include/zephyr/net/wifi.h Outdated Show resolved Hide resolved
include/zephyr/net/wifi.h Outdated Show resolved Hide resolved
@MaochenWang1 MaochenWang1 force-pushed the main_mc_add_wpa_ent_only branch from bc5dc57 to c23db8b Compare January 1, 2025 06:12
@MaochenWang1
Copy link
Collaborator Author

@MaochenWang1 the description shouldn't be copy-paste of all commit logs, it should have a summary describing the context of the changes (why, what..).

updated, please review

@MaochenWang1 MaochenWang1 requested a review from krish2718 January 1, 2025 06:14
@MaochenWang1 MaochenWang1 force-pushed the main_mc_add_wpa_ent_only branch 2 times, most recently from f3dbaa8 to 1f4799b Compare January 2, 2025 10:53
@MaochenWang1
Copy link
Collaborator Author

Hi @krish2718 @jukkar please review again.

@MaochenWang1 MaochenWang1 requested a review from Harini37 January 3, 2025 09:16
Change Wi-Fi suiteb type into WPA3 enterprise security type, it
includes suiteB, suiteB-192 and WPA3 enterprise only mode.
Support setting WPA3 enterprise only mode, which should use
cipher_config->key_mgmt as WPA-EAP-SHA256, and the AKM in RSN
IE will show 00-0F-AC:5.

Signed-off-by: Maochen Wang <[email protected]>
Fix typo of EAP method, instead of EPA.

Signed-off-by: Maochen Wang <[email protected]>
For 'wifi status' and 'wifi ap status' cmd of the hostap case,
originally only support getting 'EAP-TLS' for the enterprise
mode, which is not correct. Now support getting the specific
enterprise mode, including the WPA3 enterprise mode and
the EAP method type.

Signed-off-by: Maochen Wang <[email protected]>
Support printing WPA3 enterprise type in scan result for more
accurate display, including the suiteb, suiteb-192 and WPA3
enterprise only.

Signed-off-by: Maochen Wang <[email protected]>
@MaochenWang1 MaochenWang1 force-pushed the main_mc_add_wpa_ent_only branch from 1f4799b to 9880339 Compare January 6, 2025 08:57
krish2718
krish2718 previously approved these changes Jan 6, 2025
Copy link
Collaborator

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaochenWang1 .

@MaochenWang1
Copy link
Collaborator Author

Thanks @MaochenWang1 .
You are welcome.

@MaochenWang1
Copy link
Collaborator Author

Hi @jukkar @rlubos please review this

1 similar comment
@MaochenWang1
Copy link
Collaborator Author

Hi @jukkar @rlubos please review this

Add check that should enable MFP when connect to WPA3 network,
as MFP required is mandatory for WPA3 network.

Signed-off-by: Maochen Wang <[email protected]>
Fix wrong parameter count error when input 'wifi connect' in
enterprise mode.

Signed-off-by: Maochen Wang <[email protected]>
@MaochenWang1 MaochenWang1 force-pushed the main_mc_add_wpa_ent_only branch from 9880339 to 962fc5c Compare January 9, 2025 10:08
@MaochenWang1
Copy link
Collaborator Author

Hi @krish2718 please review again.

@kartben kartben merged commit 76fd272 into zephyrproject-rtos:main Jan 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants