-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posix: options: add XSI_REALTIME option group #83303
Open
cfriedt
wants to merge
4
commits into
zephyrproject-rtos:main
Choose a base branch
from
cfriedt:issues/82004/posix-create-xsi-realtime-option-group
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
posix: options: add XSI_REALTIME option group #83303
cfriedt
wants to merge
4
commits into
zephyrproject-rtos:main
from
cfriedt:issues/82004/posix-create-xsi-realtime-option-group
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
issues/82004/posix-create-xsi-realtime-option-group
branch
2 times, most recently
from
December 21, 2024 15:36
da74584
to
3a0cd37
Compare
cfriedt
force-pushed
the
issues/82004/posix-create-xsi-realtime-option-group
branch
5 times, most recently
from
December 22, 2024 16:24
57c39c1
to
4271c7a
Compare
ycsin
reviewed
Dec 23, 2024
cfriedt
force-pushed
the
issues/82004/posix-create-xsi-realtime-option-group
branch
2 times, most recently
from
December 23, 2024 02:23
c66b962
to
561d6c0
Compare
ycsin
previously approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reviewers might want to take a look workarounds for some weird corner cases
The latter two should be reproducible by undoing the workaround commits. |
10 tasks
cfriedt
force-pushed
the
issues/82004/posix-create-xsi-realtime-option-group
branch
from
January 7, 2025 12:58
561d6c0
to
ec1234e
Compare
|
This was referenced Jan 7, 2025
This was referenced Jan 7, 2025
1 task
cfriedt
changed the title
posix: options: add xsi realtime option group
posix: options: add XSI_REALTIME option group
Jan 11, 2025
POSIX mlock() and munlock() require an MMU as well as DEMAND_PAGING. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
issues/82004/posix-create-xsi-realtime-option-group
branch
from
January 11, 2025 14:59
ec1234e
to
174b929
Compare
For the REALTIME_MINIMAL Application Environment Profile, uncomment the POSIX_MEMLOCK, POSIX_MEMLOCK_RANGE, POSIX_MEMORY_PROTECTION, POSIX_MAPPED_FILES, and POSIX_SHARED_MEMORY_OBJECTS options. These should have been uncommented back when Kconfig options for those features were added, so this can probably be called a Kconfig bug. Signed-off-by: Chris Friedt <[email protected]>
Since XSI is composed of several distinct POSIX Option Groups split Kconfig.xsi into separate files - one for each Option Group. Signed-off-by: Chris Friedt <[email protected]>
Add a POSIX Option Group called XSI_REALTIME (with Kconfig option CONFIG_XSI_REALTIME). When XSI_REALTIME is selected (or when required POSIX Options are enabled), define _XOPEN_REALTIME to be something other than -1 (_XOPEN_VERSION seemed appropriate). Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
issues/82004/posix-create-xsi-realtime-option-group
branch
from
January 11, 2025 15:00
174b929
to
b5e59fb
Compare
@dcpleung - have some strange x86 errors here. Do they mean anything to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a POSIX Option Group called
XSI_REALTIME
(with Kconfig optionCONFIG_XSI_REALTIME
).When
XSI_REALTIME
is selected (or when required POSIX Options are enabled), define_XOPEN_REALTIME
to be something other than -1 (_XOPEN_VERSION
seemed appropriate).Closes #82004
Relates to #79816
Required changes: