settings: let settings_load fail on the first csi_load() failure #83281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settings: let settings_load fail on the first csi_load() failure and return the result Signed-off-by: Maxime Vincent <[email protected]>
maximevince
force-pushed
the
maximevince/settings-load-should-fail
branch
from
53da043 to
2389dd9
Compare
|
Let's not do this, then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings: let
settings_load()fail on the firstcsi_load()failure and return the result.In its current state, it will just happily return
0in all cases. (except when ah_commit()calls fails).The way I understand it, this is not according to the documentation (https://docs.zephyrproject.org/latest/services/settings/index.html#loading-data-from-persisted-storage).
If you guys agree with the issue (raised here: #83279),
then this is my proposal to fix it.