Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: flash: flexspi: Fix XIP during flash write #83233

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

mstumpf-vected
Copy link
Contributor

Fixes #83231.

XIP prefetching seems to still be running, even while interrupts are disabled. Therefore it is important to wait for the FlexSPI to be idle before performing a write/erase operation.

Copy link

Hello @mstumpf-vected, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@mstumpf-vected
Copy link
Contributor Author

mstumpf-vected commented Dec 19, 2024

FYI, I already contributed previously, this is my work account. My private account is @Finomnis.

XIP prefetching seems to still be running, even while interrupts are
disabled. Therefore it is important to wait for the FlexSPI to be idle
before performing a write/erase operation.

Signed-off-by: Martin Stumpf <[email protected]>
Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks correct to me

@Finomnis
Copy link
Contributor

One more :)

@kartben kartben merged commit 857e579 into zephyrproject-rtos:main Dec 23, 2024
24 checks passed
Copy link

Hi @mstumpf-vected!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nxp: mcux: flexspi: flash write interrupted by XIP
8 participants