Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for SCA with Polyspace #83149

Merged
merged 1 commit into from
Jan 7, 2025
Merged

added support for SCA with Polyspace #83149

merged 1 commit into from
Jan 7, 2025

Conversation

mbeckersys
Copy link

This change adds support for the Polyspace Static Code Analysis tool on Zephyr.
When analysis finishes, the results are printed on the console. Usage examples are provided, with an option to analyze only the user code.

@github-actions GitHub Actions
Copy link

Hello @mbeckersys, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@carlescufi
Copy link
Member

Thanks for the PR! Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request.

@pdgendt pdgendt self-requested a review December 18, 2024 11:09
@mbeckersys
Copy link
Author

Fixed commit message according to guidelines.

@mbeckersys
Copy link
Author

Fixed coding guidelines

@mbeckersys mbeckersys force-pushed the sca_polyspace branch 3 times, most recently from 46bf083 to fc16995 Compare December 18, 2024 15:45
@mbeckersys
Copy link
Author

Sorry for the noise, it took me some time to understand how to run compliance checks before push locally, and to see what needs to be fixed. All done now.

pdgendt
pdgendt reviewed Dec 19, 2024
View reviewed changes
cmake/sca/polyspace/sca.cmake Outdated Show resolved Hide resolved
cmake/sca/polyspace/sca.cmake Outdated Show resolved Hide resolved
cmake/sca/polyspace/polyspace-print-console.py Show resolved Hide resolved
@mbeckersys mbeckersys requested a review from pdgendt December 19, 2024 10:55
@pdgendt
Copy link
Collaborator

pdgendt commented Dec 19, 2024

Do not add fixup commits, squash into a single commit and force push.

kartben
kartben requested changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Please see my comment regarding the documentation

cmake/sca/polyspace/README.md Outdated Show resolved Hide resolved
@mbeckersys mbeckersys requested a review from kartben December 21, 2024 14:23
@zephyrbot zephyrbot requested a review from carlescufi December 21, 2024 14:23
@mbeckersys mbeckersys requested a review from pdgendt December 21, 2024 14:32
pdgendt
pdgendt reviewed Dec 21, 2024
View reviewed changes
cmake/sca/polyspace/sca.cmake Outdated Show resolved Hide resolved
cmake/sca/polyspace/polyspace-print-console.py Outdated Show resolved Hide resolved
cmake/sca/polyspace/polyspace-print-console.py Show resolved Hide resolved
@mbeckersys mbeckersys requested a review from pdgendt December 21, 2024 15:04
sca: added support for Polyspace tool
07965f5 
Add the cmake files for running static code analysis with the Polyspace
tools in the west build. The analysis leverages the compilation database.
Options for the analysis are documented in doc/develop/sca/polyspace.rst.

Analysis results are printed as command line output and provided as CSV.

Manually tested on v4.0.0 with various sample applications.

Signed-off-by: Martin Becker <[email protected]>
@mbeckersys mbeckersys requested a review from pdgendt December 21, 2024 15:11
pdgendt
pdgendt approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@pdgendt pdgendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kartben kartben merged commit 2871f1a into zephyrproject-rtos:main Jan 7, 2025
24 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Hi @mbeckersys!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejlmand tejlmand tejlmand approved these changes

@pdgendt pdgendt pdgendt approved these changes

@kartben kartben kartben approved these changes

@57300 57300 Awaiting requested review from 57300

@jeremybettis jeremybettis Awaiting requested review from jeremybettis

@nashif nashif Awaiting requested review from nashif

@nordicjm nordicjm Awaiting requested review from nordicjm

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees

@tejlmand tejlmand

Labels
area: Build System area: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mbeckersys @carlescufi @pdgendt @kartben @tejlmand @zephyrbot