STM32 UART ASYNC DRIVER : Fix test regressions on STM32F429ZI and STM32F746ZG boards. #82480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djiatsaf-st
force-pushed
the
fix_uart_async_f4f7
branch
from
cf6739e to
593dff4
Compare
erwango
reviewed
Dec 3, 2024
erwango
reviewed
Dec 3, 2024
djiatsaf-st
force-pushed
the
fix_uart_async_f4f7
branch
from
593dff4 to
f45fb97
Compare
erwango
previously approved these changes
Dec 3, 2024
JarmouniA
suggested changes
Dec 3, 2024
JarmouniA
reviewed
Dec 3, 2024
djiatsaf-st
force-pushed
the
fix_uart_async_f4f7
branch
from
f45fb97 to
4e2be65
Compare
JarmouniA
reviewed
Dec 4, 2024
Test cases on F746ZG work with USERSPACE config not enabled. PR zephyrproject-rtos#80944 forces the use of the TEST_ENABLE_USERSPACE config with the "select" statement instead of "imply," which is more restrictive for test case dependencies.This leads to the error "Memory region 0x2004d180 (size 8) write access denied" on boards. By setting CONFIG_TEST_USERSPACE=n, the TEST_ENABLE_USERSPACE config will not be enabled. Signed-off-by: Fabrice DJIATSA <[email protected]>
With the changes made in PR zephyrproject-rtos#76061, only on the F429ZI platform, in the test_write_abort test,the number of received data (2) is not equal to the number of sent data (1). It looks like uart_tx_abort is done very quickly, and the callback doesn't have enough time to deal with it. Adding a small delay solves the problem and doesn't affect results on other platforms. Signed-off-by: Fabrice DJIATSA <[email protected]>
djiatsaf-st
force-pushed
the
fix_uart_async_f4f7
branch
from
4e2be65 to
c858030
Compare
JarmouniA
added
the
area: Tests
JarmouniA
approved these changes
Dec 4, 2024
gautierg-st
approved these changes
Dec 4, 2024
erwango
approved these changes
Dec 4, 2024
|
Cc @dcpleung |
dcpleung
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix regressions on uart tests introduced by
This commit on PR tests: CONFIG_TEST_USERSPACE selects CONFIG_USERSPACE #80944 for Nucleo_F746ZG board about userspace permissions.
This commit on PR tests: drivers: uart: uart_async_api: Rework to allow testing of multiple instances #76061 for Nucleo_F429ZI board about non-equality between the number of data sent and received on the uart device.