boards: shields: add spi support to mikroe weather click shield #82165
+36
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
requested changes
Dec 7, 2024
| .. note:: | ||
|
|
||
| By default the Weather Click is configured to use the I2C interface. In | ||
| order to use the SPI interface the jumper settings must be changned. See |
There was a problem hiding this comment.
Suggested change
| order to use the SPI interface the jumper settings must be changned. See | |
| order to use the SPI interface the jumper settings must be changed. See |
Comment on lines
4
to
5
| config SHIELD_MIKROE_WEATHER_CLICK | ||
| def_bool $(shields_list_contains,mikroe_weather_click) |
There was a problem hiding this comment.
You don't want to let people build for this "no-op" shield
Suggested change
| config SHIELD_MIKROE_WEATHER_CLICK | |
| def_bool $(shields_list_contains,mikroe_weather_click) |
iandmorris
force-pushed
the
mikroe_weather_click_spi
branch
from
38b77fb to
a6b4aa4
Compare
kartben
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Sorry, just spotted this when searching for mikroe_weather_click across the tree to make sure there weren't stale references to the old shield: Line 44 of index.rst needs updating.
In fact, this made me realize that you also want to indicate in the migration guide that the shield was renamed (unless you maybe keep the original name as the "default" i2c and call the new spi variant/revision ..._spi?
Added support for the SPI interface which is availble on the shield if the jumper configurations are changed. Signed-off-by: Ian Morris <[email protected]>
iandmorris
force-pushed
the
mikroe_weather_click_spi
branch
from
a6b4aa4 to
5fbdca5
Compare
fabiobaltieri
approved these changes
Dec 23, 2024
kartben
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the SPI interface which is availble on the shield if the jumper configurations are changed.